Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Ico version #11103

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add a new Ico version #11103

wants to merge 6 commits into from

Conversation

GregoireLD
Copy link

While studying Ico workarounds (and being amazed by it), I discovered on Redump that there is one (quite new) version not documented in the GameIndex.yaml

I do realize that serial "SCES-00000" can look like a generic placeholder, which could spell trouble here. Yet, so far, it's the only know game on Redump to sport this weird serial.

Rationale behind Changes

Since all Ico versions uses the moveHandler: "MV_Ico" to fixes depth buffer post-processing, I though it would be appropriate to populate this entry as well, for completeness sake.

Suggested Testing Steps

Make sure it doesn't interfere with the main Ico entries, but can't really see how it might. Or if there is other undocumented "SCES-00000" discs.

It's my first PR here, I did my best to match writing style and list ordering, but be welcome to correct me if I did anything wrong.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@refractionpcsx2
Copy link
Member

According to redump this was a "Preview" version, it may be work labelling it correctly as such as we do with others.

@stenzek
Copy link
Contributor

stenzek commented Apr 18, 2024

What's the label on the disc? The ELF just may be misnamed.

@GregoireLD
Copy link
Author

According to Redump, the printings on the label are : Preview PAL ICO December 2001
( http://redump.org/disc/110819/ )

@stenzek
Copy link
Contributor

stenzek commented Apr 18, 2024

Do you not possess the disc to check? Using a random comment on redump as a source of truth is a bit iffy.

@GregoireLD
Copy link
Author

I wish I did, unfortunately I do not (yet).

I am currently tracking it, as I have good reasons to think this very build was used by a French broadcast channel at the time (the broadcast includes a red GUI when Yorna gets kidnaped, that is not present on any other known build, meaning there was indeed a European press release still unaccounted for, which this one could match).
But so far the only source I could find is indeed Redump, Hidden Palace (same info), and the mention of NomadColossus as the original dumper (He is also the provider of the Taikenban version, as well a some other versions for PS2 and PS3).

Does anyone have more info regarding this disc maybe ?

If the trail feels like it's too thin, I can understand this PR might be dropped

@stenzek
Copy link
Contributor

stenzek commented Apr 18, 2024

I'm mainly just a bit iffy about relying on redump's "internal serial". For PSX games, I've found it to be incorrect in many cases.

@GregoireLD
Copy link
Author

GregoireLD commented Apr 18, 2024

I did not know that, I understand.
How about adding a comment on this entry, specifying the serial is yet to be confirmed by an independent source ? Making sure we don't loose track of this, while in the same time keeping a record of this version of the game.

Edit : Note that on the bright side, this serial might be wrong, but so far it's unique, not referring to any other games.

@stenzek
Copy link
Contributor

stenzek commented Apr 18, 2024

It doesn't make sense to add something to the DB which can't be tested. Which you can't do if you don't have the disc.
AFAIK we also don't include prototypes in the DB for legal reasons, so we'd also want to establish that this was definitely a public release as well.

@GregoireLD
Copy link
Author

GregoireLD commented Apr 18, 2024

Would a press release qualify as public release ? If so, I will try and reach NomadColossus to make sure this is indeed is a press preview (probably the one I was referring to, I will try and confirm that too). If possible, I will also try to check with him if indeed the serial is the same as reported on Redump.

If anyone have this elusive disk at hand, or knowledge regarding it's whereabouts, feel free to enlighten me.

@GregoireLD
Copy link
Author

Still working on getting my hands on the disk, but in the meantime, I found that this entry does exist in the current RedumpDatabase.yaml and it matches the internal serial of "SCES-00000" (but it's only logical if the source is the same).

I'm also trying to confirm unequivocally this was indeed a press release, and not prototype.

@refractionpcsx2
Copy link
Member

Thanks for the update

@F0bes
Copy link
Member

F0bes commented Jul 23, 2024

Closing due to being stale. If there is an update it can be re-opened.

@F0bes F0bes closed this Jul 23, 2024
@GregoireLD
Copy link
Author

GregoireLD commented Jan 22, 2025

Hi, and sorry for the long pause.

Having finally tested this elusive disk, I hope I will be able to answer the remaining questions.

First and foremost, this version indeed exhibit the same issues as the other version of ICO when run without the ICO specific fixes (see pictures). I haven't experienced the "crash" that is mentioned in the GameIndex, but same goes for the other versions of ICO I tested so far, maybe I just was lucky.

The other issue was the diffusion of said disk. Thanks to saved broadcast footage, I can confirm this was the version provided to some Press channel, in France at least, prior to the making of the "Press Kit" a few month later. So this was not an internal build. To avoid confusion, I flagged this version as [Preview], to match both it's label, and other existing games.

Third question I was asked was about the ID, and surprisingly enough, the disc indeed reports as a "SCES-00000" and is the only one I know of to do so.

Before:
Without_Ico_Fixes
After:
With_Ico_Fixes

Even though I'm a huge Ico fan, I know this is a very "niche" edit to the game index, so I will understand if it gets dismissed.

EDIT: I don't think I can reopen this PR myself

@GregoireLD GregoireLD changed the title Add a new Ico version based on Redump Database Add a new Ico version Jan 22, 2025
@Mrlinkwii
Copy link
Contributor

@GregoireLD id advise make a new pr and just link it back to this

@TheLastRar TheLastRar reopened this Jan 22, 2025
@TheLastRar
Copy link
Contributor

TheLastRar commented Jan 22, 2025

I've reopened it, so no need to remake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants