-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Migrated Components to new Search component logic #953
base: migrateSwitchLayer
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A excepción de la primera capa, cundo hay cambio de acordeón interno, el modal de "cargando" desaparece y la capa se demora más en aparecer
- Deshabilitar huella humana histórico y EE porque actualmente quiebra la aplicación
* Set values for map title component | ||
* | ||
* @param {string} name | ||
* @param {string} gradientData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gradientData
no es un string
|
||
/** | ||
* Set true the value for show area layer | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
falta documentar el parámetro
setRasterLayers(layers: Array<rasterLayer>): void; | ||
setShapeLayers(layers: Array<shapeLayer>): void; | ||
setShowAreaLayer(active: boolean): void; | ||
setLoadingLayer(loading: boolean, error: boolean): void; | ||
// TODO: Evaluar la necesidad de tenerlo aquí |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
este TODO era para setPolygonValues
, borrarlo
setRasterLayers: () => {}, | ||
setShapeLayers: () => {}, | ||
setShowAreaLayer: () => {}, | ||
setLoadingLayer: () => {}, | ||
setMapTitle: () => {}, | ||
//TODO: "Delete when migration of switch layer is finished" (all 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Las funciones debajo de este TODO ya no se estarían usando no?, creo que ya se pueden borrar junto con el todo
🛠️ Changes
📝 Associated issues
#952
🤔 Considerations