Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Migrated Components to new Search component logic #953

Open
wants to merge 13 commits into
base: migrateSwitchLayer
Choose a base branch
from

Conversation

ManuelStardust
Copy link
Contributor

@ManuelStardust ManuelStardust commented Feb 7, 2025

🛠️ Changes

  • Set areaId an areaType to migrated components
  • Add functions to set shape and raster layers
  • Add geofence layer logic
  • Add bounds handling
  • Add handler back button logic

📝 Associated issues

#952

🤔 Considerations

@ManuelStardust ManuelStardust marked this pull request as ready for review February 7, 2025 21:30
@ManuelStardust ManuelStardust linked an issue Feb 7, 2025 that may be closed by this pull request
7 tasks
src/pages/Search.tsx Show resolved Hide resolved
src/pages/Search.tsx Outdated Show resolved Hide resolved
src/pages/Search.tsx Outdated Show resolved Hide resolved
src/pages/Search.tsx Outdated Show resolved Hide resolved
src/pages/search/MapViewer.tsx Outdated Show resolved Hide resolved
src/pages/search/MapViewer.tsx Outdated Show resolved Hide resolved
src/pages/search/MapViewer.tsx Outdated Show resolved Hide resolved
src/pages/search/Selector.tsx Outdated Show resolved Hide resolved
src/pages/search/dashboard/Landscape.tsx Outdated Show resolved Hide resolved
src/pages/Search.tsx Outdated Show resolved Hide resolved
Copy link
Member

@erikasv erikasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A excepción de la primera capa, cundo hay cambio de acordeón interno, el modal de "cargando" desaparece y la capa se demora más en aparecer
  • Deshabilitar huella humana histórico y EE porque actualmente quiebra la aplicación

* Set values for map title component
*
* @param {string} name
* @param {string} gradientData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradientData no es un string


/**
* Set true the value for show area layer
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta documentar el parámetro

setRasterLayers(layers: Array<rasterLayer>): void;
setShapeLayers(layers: Array<shapeLayer>): void;
setShowAreaLayer(active: boolean): void;
setLoadingLayer(loading: boolean, error: boolean): void;
// TODO: Evaluar la necesidad de tenerlo aquí
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

este TODO era para setPolygonValues, borrarlo

setRasterLayers: () => {},
setShapeLayers: () => {},
setShowAreaLayer: () => {},
setLoadingLayer: () => {},
setMapTitle: () => {},
//TODO: "Delete when migration of switch layer is finished" (all 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Las funciones debajo de este TODO ya no se estarían usando no?, creo que ya se pueden borrar junto con el todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Arreglar componentes migrados para áreas definidas
2 participants