-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Feature] Can set min and max values for axes. #2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@jfoucher Could you rebase the PR against the |
Should be good to go. Squashed my commits as well. Let me know if something's wrong |
public function setMinY($minY): void | ||
{ | ||
$this->minY = $minY; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function setMinY($minY): void | |
{ | |
$this->minY = $minY; | |
} | |
public function setMinY($minY): self | |
{ | |
$this->minY = $minY; | |
return $this; | |
} |
@jfoucher Can you return $this
for each setter, please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfoucher Could you update the changelog, and add some unit tests for this new part ?
(and may be add documentation on chart pages)
(It's a good start to be mergeable).
Description
This PR allows for setting min and max values for axes in Word2007 writer, by passing 4 more style options.
Fixes #1756 and #2333
Checklist: