Skip to content

[Feature] Can set min and max values for axes. #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfoucher
Copy link

Description

This PR allows for setting min and max values for axes in Word2007 writer, by passing 4 more style options.

Fixes #1756 and #2333

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented Feb 18, 2025

Coverage Status

coverage: 96.635% (-0.1%) from 96.752%
when pulling 4be6292 on jfoucher:master
into 6d75328 on PHPOffice:master.

@Progi1984
Copy link
Member

@jfoucher Could you rebase the PR against the master branch ?

@jfoucher
Copy link
Author

jfoucher commented Jun 5, 2025

Should be good to go. Squashed my commits as well. Let me know if something's wrong

Comment on lines +594 to +597
public function setMinY($minY): void
{
$this->minY = $minY;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function setMinY($minY): void
{
$this->minY = $minY;
}
public function setMinY($minY): self
{
$this->minY = $minY;
return $this;
}

@jfoucher Can you return $this for each setter, please ?

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfoucher Could you update the changelog, and add some unit tests for this new part ?

(and may be add documentation on chart pages)

(It's a good start to be mergeable).

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Development

Successfully merging this pull request may close these issues.

How to change the Axis Scale to start from 0 for Radar Chart
3 participants