Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Span<T> and Memory<T> support #23

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

Added Span<T> and Memory<T> support #23

wants to merge 66 commits into from
+1,745 −672

Conversation

Crypt32
Copy link
Collaborator

@Crypt32 Crypt32 commented Feb 28, 2025

  • Updated all methods and constructors that accepted Byte[] to accept ReadOnlySpan<Byte> or ReadOnlyMemory<Byte> (depending on need)
  • Removed long ago obsoleted APIs
  • Obsoleted most properties that returned Byte[]
  • all methods that returned Byte[] have a GetAsMemory() complementary method which returns ReadOnlyMemory<Byte>
  • updated xml-docs
  • other improvements

This release may introduce compilation errors which are easy to address by choosing correct overload.

Crypt32 added 30 commits December 10, 2024 14:27
@Crypt32
added support for c# Span<T> type by adding new methods that return S…
9ff32a2 
…pan<Byte> instead of byte array and reduce allocations
@Crypt32
updated AsnFormatter by using Span<T> and added new BinaryToString ov…
5f34a08 
…erload.
@Crypt32
added Asn1Utils.Encode overload that accepts and returns Span<T>
8822573
@Crypt32
updated Asn1Utils by using new span-based formatter
dc1d5ad
@Crypt32
fixed xml-docs by pointing to right overload.
b7b3b0c
@Crypt32
updated xml-docs
7f1afe1
@Crypt32
added Asn1Universal.GetRawDataAsSpan method
deba555
@Crypt32
changed Span to ReadOnlySpan as it should be immutable
60c502a
@Crypt32
replaced Span with Memory
f880d47
@Crypt32
added faster implementation of BinaryToStringFormatter.ToBase64, whic…
6ee6eb3 
…h is 50-80 times faster than previous and consumes upt to 2 times less memory
@Crypt32
fixed null checking for struct, which is never null
4bb52b0
@Crypt32
optimized conditions and removed duplicate code
8c3c543
@Crypt32
added few more tests
864d1e4
@Crypt32
added quick benchmark project to test implementations. Nothing fancy …
c1e7725 
…there.
@Crypt32
addressed #22
e4d9b0e
@Crypt32
improved BinaryToStringFormatter.ToHexAddress performance by pre-allo…
271214b 
…cating StringBuilder
@Crypt32
refactored benchmarks
0c2761c
@Crypt32
refactored some static methods to extension methods.
6649e8e
@Crypt32
fixed class visibility
e7ebea9
@Crypt32
refactored classes that inherit from Asn1String by moving shared func…
da53b87 
…tionality into base class
@Crypt32
moved from .NET Standard to .NET 8.0 by keeping compat with .NET Fram…
4612795 
…ework 4.7.2
@Crypt32
refactored Encode method
76d2035
@Crypt32
added few more Obsolete attributes and better way to get a copy of AS…
579f153 
…N reader that points to current position.
@Crypt32
updated ASN1 builder to support ReadOnlyMemory. Still need some work.
d3b6aa7
@Crypt32
added support for ReadOnlyMemory in ASN.1 type decoders
ef343f9
@Crypt32
added protected access to internal reader
72be4cb
@Crypt32
refactored Asn1OctetString to support ReadOnlyMemory.
33f2f0f
@Crypt32
fixed bug in Asn1Builder.getEncoded when outer tag is not copied to t…
9989441 
…arget memory buffer.
@Crypt32
typo
8905c9b
@Crypt32
added Obsolete attribute
ba0d21f
Crypt32 added 18 commits February 25, 2025 14:33
@Crypt32
refactored Asn1Utils by ensuring that methods accept ReadOnlySpan as …
e013f77 
…parameter. Two methods that use pure byte array are left for compatibility purposes.
@Crypt32
removed constructors from ASN.1 decoders that accept pure byte arrays…
9a20e1e 
… and updated xml-docs
@Crypt32
- removed redundant null checks
21297f7 
- updated null check syntax
@Crypt32
adjusted null syntax
0979941
@Crypt32
fixed raw data source
1938428
@Crypt32
clarified the meaning of Asn1Reader.GetReader() method
5ce482b
@Crypt32
added Asn1Reader.Clone() method
071f4c4
@Crypt32
optimized Asn1Reader.Clone() method
7b81f7f
@Crypt32
updated .nuspec file
95d2df6
@Crypt32
shortened .NET Framework version
af7b40b
@Crypt32
bump to v2.0.0
4d35b7e
@Crypt32
removed Asn1Builder.Create(IEnumerable<Byte>) method
2d5a638
@Crypt32
fixed ASN.1 builder encoder bugs
53ff126
@Crypt32
fixed bug in Asn1BitString.GetValue() which returns unused bit byte
b2de43c
@Crypt32
fixed bug when Convert.ToUInt64 fails to convert BigInteger, because …
9c09c8b 
…Convert.ToUInt64 expects IConvertible which isn't implemented by BigInteger.
@Crypt32
added missing default value for Asn1Builder.GetEncodedAsMemory() meth…
9c1e59e 
…od which defaults to Constructed SEQUENCE
@Crypt32
added some unit tests for Asn1Builder class
00275fd
@Crypt32
added Asn1Universal.GetPayloadAsMemory() method.
100dc87
This was linked to issues Mar 3, 2025
AsnFormatter.BinaryToString with EncodingType.HexRaw argument in encoding parameter does not respect format parameter argument #22
Open
AsnFormatter.TestInputString throws exception when input string is less than 9 chars #24
Open
@Crypt32 Crypt32 linked an issue Mar 14, 2025 that may be closed by this pull request
Asn1Utils.CalculatePayloadLength fails when header represents exactly 127 bytes. #25
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Crypt32