Skip to content

fix: method and action IR names are now separated by __ instead of _ #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

mhasel
Copy link
Member

@mhasel mhasel commented Apr 28, 2025

Updates the IR names of methods and actions to adhere to the scheme <type-name>__<method-name>.

Also adds additional FB_INIT tests to ensure proper stack-variable initialization.

Can you add a similar test in codegen?
I would like to see the case where we have a function using a function block, and that functionblock has a user_init be tested.
I expect the function, while initializing the function block call to (implicitly) call fb_init. I'm fine with adding this as a followup if we know the case works, but it would be good to express this in codegen tests

Originally posted by @ghaith in #1458 (comment)

@mhasel mhasel requested review from ghaith and volsa April 28, 2025 04:27
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (e731987) to head (1b087f7).
Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
+ Coverage   93.67%   94.11%   +0.43%     
==========================================
  Files         166      173       +7     
  Lines       50097    56526    +6429     
==========================================
+ Hits        46928    53199    +6271     
- Misses       3169     3327     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant