Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove arbitrary indirections #5122

Merged
merged 2 commits into from
Jan 28, 2025
Merged

refactor: remove arbitrary indirections #5122

merged 2 commits into from
Jan 28, 2025

Conversation

aljazerzen
Copy link
Member

@aljazerzen aljazerzen commented Jan 27, 2025 •
edited
Loading

See justification in #5119

@aljazerzen aljazerzen merged commit d4c4287 into main Jan 28, 2025
38 checks passed
@aljazerzen aljazerzen deleted the cleanup branch January 28, 2025 11:16
@max-sixty
Copy link
Member

RIP .*! But makes sense :)

@aljazerzen
Copy link
Member Author

Well, my_table.* remains. This removes {a = 3}.a. Which was supported just in parsing.

@max-sixty
Copy link
Member

Well, my_table.* remains. This removes {a = 3}.a. Which was supported just in parsing.

Ah OK! I had been looking at https://github.com/PRQL/prql/pull/5122/files#diff-18a4cdc69ea1a80da23405c8ba4471899613bb856c5675f20e6f735e8cd1170aR8 ...

@aljazerzen
Copy link
Member Author

That's wrong actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljazerzen @max-sixty