Skip to content

Doc: Clarify PPS_CAP_ENABLE description #24641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Mar 31, 2025

Solved Problem

When talking to @tobias-auterion about GPS configuration options I found that the description of PPS_CAP_ENABLE seems outdated. It mentions a fixed PWM pin which is not hardcoded anymore but can be configured.

Solution

I clarify the description taking example from #24368

Changelog Entry

Doc: Clarify `PPS_CAP_ENABLE` description

@MaEtUgR MaEtUgR added the Documentation 📑 Anything improving the documentation of the code / ecosystem label Mar 31, 2025
@MaEtUgR MaEtUgR requested a review from sfuhrer March 31, 2025 13:41
@MaEtUgR MaEtUgR self-assigned this Mar 31, 2025
Copy link
Contributor

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems likely https://github.com/PX4/PX4-Autopilot/blob/main/src/lib/mixer_module/output_functions.yaml#L62 :-)

I believe this can still only be added to the FMU, but I don't know if that clarification needs to be made here (possibly - in case user is wondering why they aren't offered this function to assign)

@github-actions github-actions bot added the stale label May 3, 2025
@hamishwillee hamishwillee merged commit 87db286 into main May 7, 2025
61 of 63 checks passed
@hamishwillee hamishwillee deleted the maetugr/fix-pps-capture-param-description branch May 7, 2025 01:15
@hamishwillee
Copy link
Contributor

Merging. No reason not to.

Louis-max-H pushed a commit to Louis-max-H/PX4-Autopilot that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📑 Anything improving the documentation of the code / ecosystem stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants