[fix]Modify follow-up push parameters and Modify the verification method for thinking length #4086
+75
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LiqinruiG
reviewed
Sep 12, 2025
| if metadata and metadata.get("generated_token_ids"): | ||
| self.append_generated_tokens(outputs, metadata["generated_token_ids"]) | ||
| if metadata and metadata.get("completion_token_ids"): | ||
| self.append_completion_tokens(outputs, metadata["completion_token_ids"]) |
There was a problem hiding this comment.
本次修改去掉metadata， 直接从 request 中取。 需要再request 的 protocol 中增加该字段，同时修改 doc 文件。
There was a problem hiding this comment.
在 request 的 metadata 兼容的逻辑中， 如果metadata 不为空， 增加warnning 提示 此参数已经过时。
LiqinruiG
previously approved these changes
Sep 12, 2025
LiqinruiG
approved these changes
Sep 19, 2025
luukunn
added a commit
to luukunn/FastDeploy
that referenced
this pull request
Sep 19, 2025
…hod for thinking length (PaddlePaddle#4086) * 续推参数 generated_token_ids 修改成 completion_token_ids;修改思考长度校验方式 * 续推参数 generated_token_ids 修改成 completion_token_ids;修改思考长度校验方式 * 续推参数 generated_token_ids 修改成 completion_token_ids;修改思考长度校验方式 * 续推参数 generated_token_ids 修改成 completion_token_ids;修改思考长度校验方式 * add completion_token_ids * add logger * fix reasoning_max_tokens ParameterError * add unittest * add unittest * add unittest * add unittest * add unittest * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Modify the follow-up push parameter
generated_token_idstocompletion_token_ids.2.Modify the verification method for
reasoning_max_tokensso that whenreasoning_max_tokensexceedsmax_tokens, its value is set equal tomax_tokens.