Repository navigation
Conversation
risemeup1111
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Communication Library
PR Types
Bug fixes
Description
Fixes #79815.
Gloo
sendandrecvadvance the same per-group counter as collectives. When only some ranks exchange tensors, a later broadcast or all-reduce uses different tags across ranks and times out. Talking to multiple peers can also desynchronize the point-to-point operations themselves.Use tag 0 for point-to-point operations. Gloo matches these messages in FIFO order per peer and direction, and Paddle already gives them a separate slot prefix from collectives. This keeps the collective counter synchronized without adding another counter that would depend on unrelated peers' traffic.
Add a four-process CPU regression covering multiple peers, reverse transfers, repeated exchanges with different payload lengths, and subsequent broadcast/all-reduce, plus a collective-only control.
Validation: the original four-rank sequence failed on the 3.3.1 CPU wheel and on the current develop
process_group_gloo.cccompiled as a native module linked against that wheel. With this change, the sequence and both new tests pass. This is a targeted native build and real Gloo transport test, not a full Paddle rebuild. The test can be run on a source build with:The collective CMake generator cannot regenerate the whole subtree on this baseline because
test/collective/fleet/testslist.csvreferences the missingtest_fleet_static_mp_layers_deprecated.py. The added registration uses the existing generator's row parser and is formatted with the repository hook.是否引起精度变化
否