Pr adapt flex checkpoint #11065
Open
Pr adapt flex checkpoint #11065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
LGTM |
From00
reviewed
Sep 11, 2025
paddlenlp/trainer/trainer.py
Outdated
| @@ -949,14 +949,36 @@ def train( | |||
| if delay_optimizer_creation: | |||
| self.create_optimizer_and_scheduler(num_training_steps=max_steps) | |||
| self._load_optimizer_and_scheduler(resume_from_checkpoint) | |||
| else: | |||
| elif not self.args.using_flex_checkpoint: | |||
There was a problem hiding this comment.
不要使用elif not这种反逻辑做分支判断，后续增加其它分支会变得复杂。可以:
elif self.args.using_flex_checkpoint:
load_from_flex_checkpoint
else:
load_from_default
paddlenlp/trainer/trainer_utils.py
Outdated
| @@ -53,6 +53,21 @@ | |||
| from ..utils.pdc_sdk import PDCErrorCode, PDCErrorMessageMap, pdc_tool | |||
| from .utils.helper import distributed_file | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
仔细斟酌了一下，发现这里不需要try，已去掉
paddlenlp/trainer/training_args.py
Outdated
| @@ -407,6 +407,10 @@ class TrainingArguments: | |||
| Whether to release gradients during training. Default is `False`. | |||
| ckpt_quant_stage (`str`, *optional*): | |||
| Whether activate checkpoint quantization. O0: deactivate, O1: Int8 compression, O2: Int4 compression. (default: O0). | |||
| using_flex_checkpoint(`bool`, *optional*): | |||
There was a problem hiding this comment.
考虑与sharding_io的互转，开关是否应该区分save和load?
|
/re-run all-failed |
zty-king
force-pushed
the
Pr_adapt_flex_checkpoint
branch
2 times, most recently
from
40c375d to
cfc3e7f
Compare
zty-king
force-pushed
the
Pr_adapt_flex_checkpoint
branch
from
cfc3e7f to
92d9b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
适配flex_checkpoint，修复dp hang住的bug