Removing the calculation of periods also from _time_index#1888
Merged
erikvansebille merged 1 commit intov4-devfrom Feb 27, 2025
Merged
Removing the calculation of periods also from _time_index#1888erikvansebille merged 1 commit intov4-devfrom
erikvansebille merged 1 commit intov4-devfrom
Conversation
This PR continues the removal of removing time_periodic in #1880
VeckoTheGecko
approved these changes
Feb 27, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Good catch - didn't see this in my first pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the removal of
time_periodicsupport in #1880, by also removing the calculation of periods inField._time_index()mainfor v3 changes,v4-devfor v4 changes)