Skip to content

Cleanup "do nothing" __del__ methods #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeckoTheGecko merged 2 commits into from
Feb 27, 2025
Merged

Cleanup "do nothing" __del__ methods #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f45a9
remove erroneous del dunders
VeckoTheGecko Feb 27, 2025
3d3b8e2
Merge branch 'v4-dev' into cleanup-dunders
erikvansebille Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions parcels/particle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ def __init__(self, lon, lat, pid, fieldset=None, ngrids=None, depth=0.0, time=0.
initial = v.initial
setattr(self, v.name, v.dtype(initial))

def __del__(self):
pass # superclass is 'object', and object itself has no destructor, hence 'pass'

def __repr__(self):
time_string = "not_yet_set" if self.time is None or np.isnan(self.time) else f"{self.time:f}"
p_string = f"P[{self.id}](lon={self.lon:f}, lat={self.lat:f}, depth={self.depth:f}, "
Expand Down
3 changes: 0 additions & 3 deletions parcels/particledata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,6 @@ def __init__(self, pclass, lon, lat, depth, time, lonlatdepth_dtype, pid_orig, n
else:
raise ValueError("Latitude and longitude required for generating ParticleSet")

def __del__(self):
pass

@property
def pu_indicators(self):
"""
Expand Down
Loading