Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce load on drain integration test to reduce race-condition failures #3640

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Reduce load on drain integration test to reduce race-condition failures #3640

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee3e780
State assert check periods explicitly - same value as in try_assert d…
benclifford Oct 18, 2024
7e28e4e
whitespace
benclifford Oct 18, 2024
a3c54c8
put connected managers poll into a variable. leave unchanged, so beha…
benclifford Oct 18, 2024
1dc7bf6
Reduce poll time a lot, to see if that helps managers start up faster…
benclifford Oct 18, 2024
676878a
Merge remote-tracking branch 'origin/master' into benc-drain-races
benclifford Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions parsl/tests/test_htex/test_drain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# last twice that many number of seconds.
TIME_CONST = 1

CONNECTED_MANAGERS_POLL_MS = 100


def local_config():
return Config(
Expand Down Expand Up @@ -52,7 +54,7 @@ def test_drain(try_assert):

# wait till we have a block running...

try_assert(lambda: len(htex.connected_managers()) == 1)
try_assert(lambda: len(htex.connected_managers()) == 1, check_period_ms=CONNECTED_MANAGERS_POLL_MS)

managers = htex.connected_managers()
assert managers[0]['active'], "The manager should be active"
Expand All @@ -63,7 +65,7 @@ def test_drain(try_assert):
time.sleep(TIME_CONST)

# this assert should happen *very fast* after the above delay...
try_assert(lambda: htex.connected_managers()[0]['draining'], timeout_ms=500)
try_assert(lambda: htex.connected_managers()[0]['draining'], timeout_ms=500, check_period_ms=CONNECTED_MANAGERS_POLL_MS)

# and the test task should still be running...
assert not fut.done(), "The test task should still be running"
Expand All @@ -76,4 +78,4 @@ def test_drain(try_assert):
# connected managers.
# As with the above draining assert, this should happen very fast after
# the task ends.
try_assert(lambda: len(htex.connected_managers()) == 0, timeout_ms=500)
try_assert(lambda: len(htex.connected_managers()) == 0, timeout_ms=500, check_period_ms=CONNECTED_MANAGERS_POLL_MS)
Loading