Skip to content

Conversation

@yadudoc
Copy link
Member

@yadudoc yadudoc commented Oct 14, 2025

Description

The GCE testing CI action was not setup to install parsl from the local repo but was installing the Parsl version pinned to globus-compute-endpoint. With the latest parsl not installed, running tests against the endpoint would trigger errors as @benclifford mentioned here:

E                ModuleNotFoundError: No module named 'parsl.tests.test_python_apps.test_exception'

Type of change

  • Bug fix

@yadudoc yadudoc force-pushed the test_gce_test_workflow branch 2 times, most recently from 0ece88d to 3bfdfc9 Compare October 20, 2025 21:33
@yadudoc yadudoc changed the title [TESTING] Fix GCE tests in CI Fix GCE tests in CI Oct 20, 2025
@yadudoc yadudoc marked this pull request as ready for review October 20, 2025 22:03
@yadudoc yadudoc requested a review from benclifford October 20, 2025 22:03
@benclifford
Copy link
Collaborator

this is going to break in the same but different way when the Parsl API or internal not-API changes in a way that the GC endpoint hasn't tracked yet, right? (as an example, JobStatusPoller going away as an independent entity and merging into BlockProviderExecutor would be a likely thing to happen in the next two years)

@yadudoc
Copy link
Member Author

yadudoc commented Oct 21, 2025

@benclifford Yes, that is likely to happen when either Parsl or GC makes changes that are incompatible. The other option is to make breaking changes in Parsl get that released and have GC update the parsl pin to the latest. This seems far more tedious than the current solution here. Or, we drop support for GC entirely.

@benclifford
Copy link
Collaborator

If these tests are going to be subject to continuous awkward catchup games from the GC team, I guess thats fine although I would prefer it not be that way. But probably the GC team should be reviewing its own PRs for that, rather than me.

Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like BenC, I'm not overly pleased with this current state of affairs, but I don't have an immediate better alternative either. I'm approving this now to "move on," but I expect that we will causally revisit this entire plugin at some point.

@khk-globus khk-globus force-pushed the test_gce_test_workflow branch from 3bfdfc9 to 79fa14b Compare October 29, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants