-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iconv functions #109
Add iconv functions #109
Conversation
Thanks! Sorry for the delayed response. The following points I like to hint to or ask about:
Best regards |
We already do something similar for I've asked this in #62 but didn't really receive an answer - do we want to go all-in and add definitions for all the cstdlib-like SDL functions? If so, then I'll follow up this PR with another one (or more) adding |
Thanks for the elaborated answer. I see your point, the main reason why I stumbled about this, is the introduction of the Please fix this PR to be Delphi-compatible. I'm sorry, I forgot about your reply in #62 . Let's discuss this in general there. But to answer your question
I would suggest to go for addition of cherry-picked, useful SDL functions if it is worth it. To my mind it is worth it, if we can prevent adding new units (dependencies). Best regards |
Thanks for the insight regarding Delphi compatibility. I've pushed one more commit that should include the proper unit based on the compiler used. Sorry for the long wait. I'll follow this up with a couple of PRs introducing some cherry-picked functions from |
This changeset adds
SDL_iconv*
functions and related types.Note: Since many other symbols found in
SDL_stdinc.h
are missing from oursdlstdinc.inc
, some changes have been made:Strings.strlen()
is called instead ofSDL_strlen()
, where approriate.SDL_iconv_wchar_utf8()
macro is not included in this changeset, as it requiresSDL_wcslen()
.