Remove empty record types #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL's API contains a lot of opaque data types, where the user is given a pointer and is expected to never dereference it. Until now, we used empty records to denote such types, and then defined pointer types to said empty records. This commit removes all(*) the opaque types and instead declares pointer types using the "type Pointer" notation. This makes it clear that the user is expected not to use the "raw" types, only pointer types, while maintaining type safety. Check the discussion in the link below for more details about the rationale behind this change. PascalGameDevelopment#63 (*) units/sdl2_net.pas still contains some empty records. However, that file is very messy right now and needs a proper rewrite.
|
Hi, thanks for this update. Could you update this file, please: Best regards |
This change reflects the recent change in favour of using "type Pointer" instead of empty record types when dealing with opaque structs.
suve
force-pushed
the
remove-empty-record-types
branch
from
334bbe8 to
89ac010
Compare
|
Thanks, I like the details in the cheat sheet now! |
Free-Pascal-meets-SDL-Website
merged commit 0fcaf6a
into
PascalGameDevelopment:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL's API contains a lot of opaque data types, where the user is given a pointer and is expected to never dereference it. Until now, we used empty records to denote such types, and then defined pointer types to said empty records. This commit removes all(*) the opaque types and instead declares pointer types using the
type Pointernotation. This makes it clear that the user is expected not to use the "raw" types, only pointer types, while maintaining type safety.Check the discussion in issue #63 for more details about the rationale behind this change.
(*)
units/sdl2_net.passtill contains some empty records. However, that file is very messy right now and needs a proper rewrite.