Performance increase#19
Open
AdamFrisby wants to merge 1 commit into
Open
Conversation
Reduces memory allocations and slightly increases performance
AnmAtAnm
reviewed
Apr 17, 2019
| Translation = SubInstance._sensor.Translation; | ||
|
|
||
| float sensitivity = Application.isPlaying ? Settings.PlayTransSens : Settings.TransSens[Settings.CurrentGear]; | ||
| return (SubInstance._sensor == null ? |
There was a problem hiding this comment.
Testing SubInstance._sensor == null twice. Can be put at the top of the method with an early return.
AnmAtAnm
reviewed
Apr 17, 2019
| Rotation = SubInstance._sensor.Rotation; | ||
|
|
||
| float sensitivity = Application.isPlaying ? Settings.PlayRotSens : Settings.RotSens; | ||
| return (SubInstance._sensor == null ? |
There was a problem hiding this comment.
Again, testing SubInstance._sensor == null twice. Same solution.
AnmAtAnm
reviewed
Apr 17, 2019
| public override Vector3 GetTranslation() { | ||
| public override Vector3 GetTranslation() | ||
| { | ||
| if (SubInstance._sensor != null && Translation == null) |
There was a problem hiding this comment.
Match the indent of the rest of this method, especially since you're not using { } (which I would highly recommend using).
There was a problem hiding this comment.
Here is a real-world example of why you should really use curly braces (TLDR: major security failure in Apple's SSL).
https://blog.codecentric.de/en/2014/02/curly-braces/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces memory allocations and slightly increases performance