Fix Accessories mod items not being stored in graves (1.21.9/1.21.10)#215
Open
nnmrts wants to merge 1 commit into
Open
Fix Accessories mod items not being stored in graves (1.21.9/1.21.10)#215nnmrts wants to merge 1 commit into
nnmrts wants to merge 1 commit into
Conversation
Updates AccessoriesCompat for Accessories 1.4.x API compatibility: - Changed `return` to `continue` in the addToGrave() loop to prevent early exit when encountering empty slots - Removed call to slotType().dropRule() (removed in 1.4.x API) - Updated ExpandedSimpleContainer to ExpandedContainer (moved to impl.core) - Updated DropRule import (moved to api.events) - Updated build dependency to accessories-fabric:1.4.0-beta+1.21.10 Fixes Patbox#210
nnmrts
force-pushed
the
fix/accessories-compat-1.21.9
branch
from
19bcc04 to
ae2a152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates AccessoriesCompat for Accessories 1.4.x API compatibility:
returntocontinuein the addToGrave() loop to prevent early exit when encountering empty slotsFixes #210
Would it be possible to create a 1.21.9 branch so this can be properly targeted? Otherwise, this PR serves as a reference for the backport.