Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PatchMyPC-CustomAppsHelper.ps1 #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pbarsan
Copy link

@pbarsan pbarsan commented Dec 16, 2024

make it compatible with PS 5.1 where if no match is found, $matches[0] will contain an empty string (''), and $matches will still be populated with keys (like 0 for the whole match and additional group captures, even if they're empty).

Pull Request Type

  • New Script
  • Edit Script
  • Repository Improvement

Brief summary of changes

Describe what you changed or added, and why you think it would be helpful to the community.

Describe your Testing

Describe the scenario this script would be used for, and how you tested it.

Checklist

  • Did you Clean your script - No environment details, comments are PG-13
  • Did you test your script
  • If required, did you create, and include a Read Me as outlined in Community Scripts Read Me

Notes for PMPC Team

Include any other generic notes for the PMPC review team here.

make it compatible with PS 5.1 where if no match is found, $matches[0] will contain an empty string (''), and $matches will still be populated with keys (like 0 for the whole match and additional group captures, even if they're empty).
@pbarsan pbarsan requested a review from a team as a code owner December 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant