Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Against the Darkness applying to all Jewel sockets + fix reistances not updating in side bar #2

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 18, 2025

Closes PathOfBuildingCommunity/PathOfBuilding-PoE2#204, PathOfBuildingCommunity/PathOfBuilding-PoE2#233

Description of the problem being solved:

Fix allocated jewel sockets applying variant 1,2 Against the Darkness stats to every node in radius when we calculate resistances. also fix the sidebar displayStats to update with Against the Darkness when allocated.
The first fix checks to make sure Against the Darkness is socketed, the second fix returns the modList that processStats creates, which the function expected before I made the ATD changes.

Steps taken to verify a working solution

1

  • Open build, hover ATD jewel, validate it's not adding tons of resistance to every socket by default
  • Then, add ATD to any socket, validate mods are added correctly
  • Save and load ATD socketed, validate mods
  • Save and load ATD in items but not socketed, validate mods

2

  • socket ATD and validate resistance on sidebar and resistance in Calcs mach, validate sidebar updates in real time with ATD socketing

Link to a build that showcases this PR:

eNrtPFtv2srWz-VXWEhH2lshiWd8j5J9RG4t3blQSJrdvlQTPIBbY1PbBEiV_37WmrHBEGxMeqTz8H19SMBe99usWTPp8b9nI1954lHshcFJnRyodYUHvdD1gsFJ_f7uct-u__uv2nGbJcPb_unE8_EN_av27lh8UXz-xH1AVAGx57M4vmEjflJ_8JLesK6wuMcD92z5vBX0eRQw34uTupKwaMCTzxlz9RsBGkMWsV7Coysk3Jwk4XXoAmISTXhdGTEv6Ia9Hzx5H4WTMfCtK08en0qY1nX7tnNXB-HeHbd9NudRN2GJEsOPk3oTlGQD_sEDxk_MnwC8Wj8shT2dRHFyzkbwcTtOd8y5uwAjRWBnkZdcT_zEG_sejxbwtAge5D0bsqC3lABNXQB8FybMP293t0srIcMKtgBPDk990K0SXYRuDQIv4ZXB26EXh8FOUlcCPpv4PsRqJdgOj3n0xBKvoiBn4ejRCyra5JoF7CyMk2qQbR5BziQ7IXR5L4Q025XHjphXXp9Xh9xJjxRhV2nepsdFtyrczoTfJlAHCkw1yG448StCJsviYhWH_c88HCmkds5ny1JVCNUKloJRrYxrHpIYVjHbpxBzsmJluPjQXuqsO-aBqjk20TRdc4rw2sN57PWYf81m3mgygmp7x37wJUNTVbXiCBwMkwBKTCEysc0i5Esv4kV4FtG14srju0V4uqbbhXhDFsaFiBbVy_Is5yvDKVkAe0cI3Qp6C4R9Wkb3PohE4c0vnCUcEKUDeYWr86PPK-Ms2aT5WWUtlcwGPEg5zpdI1kEpuyvOe8P30Kl0WMKrFeS8QFapgRF6xcCklPAmC5ewWEXZwVqIuNlapn1AyrB2tFZ37EW5Fk4rTk8JucEAO-DsYIGLgEeDeXfocX_JStd1UgUhs9oZG1fCFaGQJ5APCV2j1Xhuclcl_Xb02QOL3Gqr4K4yPbE4vzxQrdxgEjxvq-KA5tDzAoLL19rvQox2FH7nvcTzd0NrRqNwslyDdbNUBQmd10Azt61tcgfT4e6kV20xvej3UZEnfurDXmtNEd05cIytmCCs729CL7ZDkrDej_PQHVQ2nWCyE8aqfN3JeAyZjjFRlQAu27BZ8HItGHG2A99CPOdzWy1b3tfo72vGdujKDBZNyxoXsyJCdU2w4VhnYlWArsxh4cxrKBcjKNNiC34d5moNhGqh8S5hf1hp_yYAK2462-EUpB_iYCPeDRp6s2VOF4oS8eB5Xpn-CnglBheBO4kwFSrzWMfYxOZ00u_HSg82zSy5Ahef1OvKIzzLPvcmUczTLxLjzhtBAY7jc5YwxU23AZ9Z5LEgoWLsE3MW9YaIdMl8_xFqB1JaPhXfxKjo0vMTHp3DMxQTVVmnSLKBzfGhmGrhp9ZoHEaJwmf4q82iZH5S7zM_5hJQPAE6ceIFYm4AFcz360p3GE6b7hNyugtDP86QFDYe88BdoXEXca6wrB71UAihPH5RRiwGqecyyGPUJjdMa7nCBkEIAsAnYlq0odmWRhumRYwGNR3daBjQQVgN3TEcrWE4pmbCT0MnDaISjTQocWy9oatUVRvEphr8IKbaoA60Dw1iaIbdIJqhAQFLcxoU9lOAaVHqNAyL2g1N14Gs5him1SC6ZGdQ0tAsxwKyOjWMhq0Z8NKwbQMwDfzhWFrDcoCNQZCwDnRAViAJQPDZMhwdhCeO2dDgsQ5gBIWEB4BN4CkKqlGDNEzQTW9omklAZwIQDUotW0NY1WhoxNRUoGECuElt22oYKqgHMpqgnaVTHdS1QWiiWaaDyoCJVIuC_lQjyFEHGVWiAgvDBnEoNUAyaoOGum0S0BPINqgGAgF7W6dgSZMAfccE0roBmukWMUEnE-iiEVQHNABuDU2lICAFFKKCJKADBWaAhx_BwGA8SwNFbAOUBu8RpC1UswAR9ANH2A581whYFU0A3jRQagJqOCCOSkFgDXAaummA3MAAbGWCauhfFSShtg6oOrXAp7almw3T0EAf3aGGiYKDs6htgLN06T3dNDF6QGkQAIRsmBq4G90MzkPvo0YQeCY1LbC1CWEB4CpECMEYBHYQToZBbGFgB52iQzxqjooBZqsgGHgGXK3ZjkUxjXF6wqJ5czXmAw9SLIG0WRsaZ-81kUDvju87V-LDu2GSjOOjw8PpdHowZskw7PMZdGgHUIsOx4AEqbcf__B8fx-pHjbh3-ng-pTP6RdfnbJb6p9OH4PQufU-fzRuPusf1dbpzHlvf7jSb7_pqt75-5zRm_O7ztfBMKLs-_N4SNqj-88_n_utv-_3zz89Pna-3_ffN1uXF-Ezu_94xb763U-DuD8N99Wm27Sezq_aFg1vrq395Ms383bGdbN9_u0hmIXnn9mp2ux-Vcn8E3meeaf__D1sxlPLu75tfr996D44-lSPH8jj7Mfgm0uiTzq5Gja_j2Nn2p1Nz5yL659eQAfuwP8Z3ppRRJ2kdxkGqt112acPrZlrzPSb_uV1S_-6b3gPHiM0sJg9-zq7f7Cti7-dj7dP9nT63tOv6b4bP6tGd9L3wq_P-i1Tr6Zd-_r7t7vPWvA8Ip8egsd59M_3S9ew97tf-o8TntydfWmDPYVDDjOPHMvxfXwov-FiH3lQxaS7jqELjLzHScKzF1BiZzeyzNUVL0huVkqeiB8Z0jLUZW1Lo1b8lFErA1NUDplSMq3zCSeTWUZtlnAigzFf0-ImEknWBWNRJ0ThhZhNokzQVLnDFe2OD7Gui0UGCz9-uAkT-Q4fZl-OuxiPMSxeUfKej-LTOXQel7jtWps7pysHQnd5IhfFPE52aOLyPpv4-PzThPkeLmRq_umVPMIJwmi0GIQBKVjIsEGWFO_mY9SseXWVLlEpV8Vzs2UrfSjOaJpL0c6Y34uFcF7Q8ycubwVp57VYGn32iAKg-JMIV-hWwkdH9OiW_YinYRQ0lK438HzlDJr1RMm22DzAIZCbaRn7IW41ORuHgULr62IspHx3DOqI3gXEbwUQXmlZkfTe--Ej8-lStvR8a_U9WXBF2lh5pFRixyNbpLryM2ftgI3SNb7DvJgXKdELJ0HqyZyAqQlRyiyyhE5pVKWuEJElYwc_CiQB0QrGk0RIcFIfeXHvG7ZeeGImYlYc9F1cXl6c3bU-X6TtVx5FqPgtmIweUSn5e3nA1eViU6nEk8dYfjypf_b4VAhyzhPm-THq5ftsHPNF_yPiJpXcB7wSagLqg7c4iNtMawlQTOlixiNo1wYP0CNGHi-Ua_F-i1CSIc4qsF0tooanbMWE5Lb3DJo9OUspsJQ4XCymgqeKhergyxJcaHSZX8g5fbvFEgmWBwhvr-_1cG9Q7nIsJhKqxC492BSw3rzE3-mevZiGOLYsIiBfFiPLY8ki7PRtiVXFIWihVeXbYvRz3mOFusuXxciL8VwYiOPuzVQWUCWUbsJABDkkTdPzcY9d6NkLny9AigneJkMepXuaIkrXUKMykNLEkZ1CIZ0cRImtxPFGgYXwXTGqHNwX6IDvSpImnWIXZbtXnrKrs-YCf-RhiknJ2WxhHSxDleOaQvOns58SD6aTzwLvybclRsiGvwX6p69LckyU7-ZT6Lly-FeQbWtgZfUGVv_fJyMmmr9PZn3E-fsUL2Gb9aPQ3-nbYvT7xMN-aAMV2fxUIoI5-XsUMDV_jwJOukZvxu6sdzFL3E55_7KYyW1Ezt6WlY10VPdmCnKg-GZ0Me98M7ZYO855n4MGpYvHAqYkOZJJcA7GSEoSoyIpIdbmKrLUbidachndqOnOFGV2p8f9ZQVAgmwhBH3Ah5JOsxqlxdz-A2c-3v8K_d8j-Opaw-8Qw9PHyZgFbkbudlN_v_RDReuFSQw0xXT5HA85f9eGAR_NNxAqluv4MNsRirkz7tHSaXk3iXDz_RyGoy8ndUs1DzTbpuk_-TwdEVjpWAB693MPvBiJ6Mu4IuA_J3VNdw4syzQzAoI57ujjdGKBnxcDi2Jyk5jLS1RyTy8wpJ3kFhWo5KcPHQY90_xI6TQ7F7UbUA4BarCpSvAWoNLt8XES8ZrsrY4Uopu1s4j1E-4eKciw1o5435sdKb-gRA74kXrgaNrLVdhjfivoRZyBfSVyM3BxDdFeY1CbviyAEYbQ10CGYb7cgOEf503fh11m03W5uzhlk25zal3Yo6-g6SpZQcNdHZ7ugve8H-kBqP4ajTjWCtpCPNxyim3lBiSNWi9y0HHtBRBvspXArVs2LpI-0WvpROlIoWpNvOjwn0eKSWqwb_S9HtQKMHXtPRBOYkVQOFIEnPIH2afqn_AM9v8J8xVoNiMvjGqU_gsnRVJIRVq8tgdqKEmojGSmK2jbmlQIgJU5dIpKGy9tgBEUF8qKoiG4SRTmuh6mDDySW21lYWpF2rqQzpA9cYVaeXEyoytQHBRp83J0Yq-gM5xfodFrezoKKE0R9hXm-4q0tbRSLMY816HbQZcowjF4nmnI5KbZIKgQQtsKkZ3FHmKirKYUXU2p-5vWp_uLWjaOq72extVkt36k6KQmNx7pC_C-sxIk6fj3SOnWOpOAw-9wArTCiKMZ2pPhhEUJz8WSlQ8lWvsFtgW7Jy-_IkB_2SP_QjumK4CCJ-6K3HgI36wGXn70Vlvm48sfurpvqn_mPSVaebyMjlSWoJb28oet7hO6Ci21V6DAKyva1371wiiajKHICB8ckQOiv-wZKsqchnZOjr0_iLVPtT-FSuJEPK_LWUaq3K1kq-N_L3gsTcLoW6kYWyHM4hDUyqr6xWzMo0R58CCWIuXOYxF7FXY63VbfDdNaq-_5PXN69Yu8xiOGsazyuB8h6msgjayuBHS9ypItFZa-LsuGZb0s75RsqNuObb4s7i1y2d1a5enXiqDk4Md8-TZWy_dazlH1dew3lHS_vSEJKMnDr77bI4aeL-woPTy0XxX7PbqlXu5RTeTNegnA25qCrJK3igIBlJ4y_m_T6b-eTG-r-HqFdGv6CYuUTvjI15PN1O1tyWbpZkmy2ZuzbGt2bsBzHHM1O80NTZHI4ARSzhvgWm2_BlF1-rJ29cne3F3lri6ZBbm2IduKs88ySlc8fcfs-5WwQXzExbNvsXjWcNN948vaImjgstYXF0_wAAp8Dqm2Qg6SqCc26rU9S80n6SpTotKSnLc3pLxG8FneKdAiycV92bDl0nqPGpuXyf9r2VwCYRfnu1Eh37vh6BFqKSxTTzx-lfLWtozXVHN7Am_YH6mqtUzg7BjI3FAgTLqa6PbmRD_nM4hnUFPbkOX5BXVDoTAoyee3sUMre-YlDE-Aw8SvvrTuyaDG1e3CF3caYa-xDO64ppXlFTHFupnZDPpdPO2E56q2YY0VzxbGwQzcuH7u4Ybs_xPtVRrh5YfiEcXqvQgIAsUDnPbjfecKZy3yZF1mVl28auWFLUJIbzeQJQrZhiLG0XkMdRtGczSBHfkOCGIcrmg7Y2wUSuRUywVwcbsRX4rLahnqRz6FDjB9lCddyQ60Kku8HLnGUj7ageXyLkrGk5bxFLcYV3mmj3bgecr9pKqOeM9yTUf5aHcdidKd4pXtyhHQweW8qjfwxuiqoPLJLnYJ3bmSHThmTPWqHnyTdmTnhKhqD3Hlc9Ug6aMdLPKB-6N8mmvbTRgm8SsJZVWU149wssxcKIk4VX7g2LbFcvQsxr_iVlIY9L1BOgiWX9JRsMBfPFESL_E5XnUQt9RW62nbZz0-DH0X2lQpG8dxePoX-NkNJUtdGLEAYeVPFDK0bUhrk9rcjSiV0m0Mo-Vf82doRjFOdwjO7-LQMn518aqYBzx5g2i47L8BTXQ2SwxbL4YfLf7XA_yrfx5xV6h2hlfeutzv5_gaFXRc95tR2XFtPCLK0LSqWDvzE9G1blJddSo4YmdeiLSTWmjBqgjdXihOiXaMw2h5ZW_BZJseWYVeMKG2sw0n_fO20PdF-5YvAMWYMY6wb_viQBo0E6fqVTVbXDxZRH1Z2AuU1T_F25Rhx4eL2icP68S3v2rHh6_-65X_ACRkA40=

Before screenshot:

image
image

After screenshot:

image
image

fix displayStats with ATD jewel
@Paliak Paliak added the bug: behaviour Behavioral differences label Jan 18, 2025
@LocalIdentity LocalIdentity merged commit 4b36dea into PathOfBuildingCommunity:dev Jan 18, 2025
2 checks passed
@LocalIdentity LocalIdentity changed the title Fix resistance bug and Against the Darkness displayStats Fix Against the Darkness applying to all Jewel sockets + fix reistances not updating in side bar Jan 18, 2025
@Peechey Peechey deleted the fix/jewel-socket-res-and-displayStats-with-ATD branch January 19, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passive Tree nodes grants cold resistance
3 participants