Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Movement Speed mod on Gamble Sprint #39

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

CarnegieL
Copy link

Fixes #112 .

Description of the problem being solved:

Gamblesprint not showing movement speed modifier. Check for modifiers with '0' value filtered out the mod. Added logic to allow this one through.

Steps taken to verify a working solution:

  • Verified by looking at item in Items tab
  • Verified variants in line with 0.1.1 patch notes

Before screenshot:

image

After screenshot:

image

Added special logic for gamblesprint to make it through to the tooltip.

Previous logic filtered any line that had 0% in. Special case added for gamblesprint.

Issue #112
Base Block Chance calculation change for shields when Renly's is allocated
Forgot to remove experimentation lines! Rectified
Misunderstood the variant system. Updated again
@LocalIdentity LocalIdentity changed the title Fix for issue #112 Show Movement Speed mod on Gamble Sprint Jan 18, 2025
@LocalIdentity LocalIdentity added the user-interface Changes that only affect the UI label Jan 18, 2025
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These boots still have Lightning resistance on them:
https://pathofexile.com/trade2/search/poe2/Standard/D0Kk8Y4u5

Also unique changes should be made in the src/Export/Uniques files first, and exported to produce the output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gamplesprint missing movement speed mod
3 participants