Support for Thorns Damage

[madxmike]

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

POE 2 introduces thorns as a mechanic for players to build into. This seems to be different to reflected damage found in poe 1 (such as on Bramblejack) or on mob affixes as it appears to not scale with the damage taken on hit. My testing in game seems to align with this, but I haven't been able to get high enough on a thorns build to really tell, so I may be wrong here.

Thorns seems to act mostly as a triggered attack seperate from weapons or spells with its own set of phys/ele damage, crit chance, crit damage bonus etc.

https://poe2db.tw/us/Thorns#Acronym

By default thorns damage only triggers on enemy melee hits, but has the ability to be all hits from Thorns damage is triggered by all Hits mod on https://poe2db.tw/us/Crown_of_the_Pale_King

Thorns build: https://mobalytics.gg/poe-2/profile/6f6fba9f-ff73-4a9b-9c8b-e51b091c06a1/builds/a41cf294-c954-40b2-aed4-307e9168fff9

Describe the solution you'd like

My mental model for thorns is that it is a separate skill that the user can select on the skill calc dropdowns. If the player has any thorns damage on their build the dropdown will include a thorns "skill" to select. This would be subject to the normal damage calcs.

Describe alternatives you've considered

No response

Additional context

Items to test in game:

Do sources to + damage (such as +# to +# physical damage added) effect thorns damage?

[madxmike]

Do sources to + damage (such as +# to +# physical damage added) effect thorns damage?

Does not look like it.

With item with + 4 to 10 added to attacks mod

With item off

Looking into the game data we see thorns as its own damage type (idk the correct name here) separated out from spells and attacks

Presumably, global damage mods should effect this, but otherwise it seems to be completely separated out.

[madxmike]

Got a wip version working locally. Will put up pr tomorrow.

From what I can tell testing in game, thorns does not count for most "on hit" mods and does not apply bleed or poison. Shock/chill/ignite seem to work (? need more verification)