Add initial implementation of thorns #785
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760 .
Description of the problem being solved:
This PR adds an initial implementation of the thorns mechanic. See #760
We detect if any thorns damage adding mods are active on the player's gear. If so, we grant a custom "ThornsPlayer" skill. This is inspired with how explode corpses is implemented in pob1.
DRAFT: Putting this up now as I have the skill and mods working, but Im not sure if this is the best way to implement this. Wanting feedback. I still need to test this mechanic a lot in game to get a full grasp of the mods that do and do not effect thorns. So ailments and other on-hit type things will certainly need to be adjusted before this is final.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/ln53d00j
Before screenshot:
After screenshot: