Skip to content

Add initial implementation of thorns #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

madxmike
Copy link
Contributor

Fixes #760 .

Description of the problem being solved:

This PR adds an initial implementation of the thorns mechanic. See #760

We detect if any thorns damage adding mods are active on the player's gear. If so, we grant a custom "ThornsPlayer" skill. This is inspired with how explode corpses is implemented in pob1.

DRAFT: Putting this up now as I have the skill and mods working, but Im not sure if this is the best way to implement this. Wanting feedback. I still need to test this mechanic a lot in game to get a full grasp of the mods that do and do not effect thorns. So ailments and other on-hit type things will certainly need to be adjusted before this is final.

Steps taken to verify a working solution:

  • Loaded build below and viewed thorns damage calcs

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/ln53d00j

Before screenshot:

After screenshot:

image

@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 4, 2025
@Nostrademous
Copy link
Contributor

I started it, but never finished. I am assuming you are tracking #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Thorns Damage
3 participants