Add support for Berserk Gem#813
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Mar 10, 2025
Merged
Conversation
LocalIdentity
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Berserk gem was not implemented in, this solves that.
One small issue that I'm not sure on, which would also apply to PoB1. Rage effect doesn't seem to apply when the config is only 1 Rage. Not sure if it's intended, but I thought 0.2 leech would become 0.3 with 50% increased rage effect? When it's set to 2 Rage, it correctly shows 0.6 leech. Then 3 Rage is 0.8, then 4 Rage is 1.2. So I guess the effect is "additive" where it needs 100% total effect to add another stack of the mod, if that makes sense. Is this how it should function? Same applies for the life degen. Apologies if I didn't explain it well enough.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/35ep600u
After screenshot:
This is with 10 Rage set on the build I linked.

