Skip to content

Comments

Add support for Berserk Gem#813

Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Blitz54:berserk
Mar 10, 2025
Merged

Add support for Berserk Gem#813
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Blitz54:berserk

Conversation

@Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Feb 21, 2025

Description of the problem being solved:

Berserk gem was not implemented in, this solves that.

One small issue that I'm not sure on, which would also apply to PoB1. Rage effect doesn't seem to apply when the config is only 1 Rage. Not sure if it's intended, but I thought 0.2 leech would become 0.3 with 50% increased rage effect? When it's set to 2 Rage, it correctly shows 0.6 leech. Then 3 Rage is 0.8, then 4 Rage is 1.2. So I guess the effect is "additive" where it needs 100% total effect to add another stack of the mod, if that makes sense. Is this how it should function? Same applies for the life degen. Apologies if I didn't explain it well enough.

Steps taken to verify a working solution:

  • Copied the code from PoB1 for the life regen mod. Which is related to Rite of Ruin. The life regen scales from Rage Effect.
  • As the regen scales from effect, I assume the life leech should also scale, and that's how I implemented it.
  • Rage effect increases properly, quality increases effect as well.

Link to a build that showcases this PR:

https://maxroll.gg/poe2/pob/35ep600u

After screenshot:

This is with 10 Rage set on the build I linked.
image
image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Mar 10, 2025
@LocalIdentity LocalIdentity merged commit c616c24 into PathOfBuildingCommunity:dev Mar 10, 2025
2 checks passed
@Blitz54 Blitz54 deleted the berserk branch March 10, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants