Add support for Ice Crystal life #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
A small number of skills have Ice Crystals, and two nodes on the tree affect crystal life. I tried to copy the Perfect Timing section, as I think showing the modifier values in the breakdown is cleaner than having a separate breakdown only for the effect modifiers, considering Ice Crystals aren't exactly the most important thing.
Also the description for Frozen Locus has a buggy Chilled Ground section. It's missing level scaling. So the displayed Ice Crystal Life shows 43 life at level 1, and 1 life at anything above. Related to that, Ice Nova Cast on Frostbolt has a similar problem. No level scaling, so the spell min and max damage shows 1-1 at anything above level 1.
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/ku3l10ii
After screenshot: