Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gruthkul's Pelt disabling on hit curses #8522

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 23, 2025

Closes #8484

Description of the problem being solved:

The 'Your Spells are disabled' mod found on the Gruthkul's Pelt unique chest armor currently prevents curse on hit mods from applying. This is due to the 'chance to Curse Enemies with X on Hit' being implemented in POB as a simple granted skill without making the distinction between generic granted skills and on hit (application) skills (curses). This solution isn't the prettiest but i'd argue it's the most sane given what information is available to the ModStore.

Link to a build that showcases this PR:

eNrtXFtv47YSfl7_CsJAD1p0E1uSb8lJWjhxbkCym9rZ3dOngpHoWCe06EpUErfofz8zpCTLjilLtvft7AKJLM43N5LD4ZDOya9vU05eWBj5IjitW4fNOmGBKzw_eDqtf3m4POjVf_2ldnJP5eTz-Cz2Obb8Uvtwop4JZy-MA65OJA2fmPyacnL-AE4zGsgJE8Ed_a8Ir4R3Wv8kAlYnjzTwfJl-cjmNok90yk7rIxfAdUIjlwXe-eJ9QjihIXUlC29Raj-W4k540CrDGFqn1A9Gwn1m8ioU8QxUqJMXn71qmpu7-8_Dh5xKfpBXCSz6cHLP6ZyFI0klieDHab0PjqFPbECn8BO4UR4Dq17zsNu2e0e9lmN3j3r1RiH4LA4juR2H0YwxLwNZh3bLMpHeh-xiPGau9F_YeejL8wkN3IXAzqERuYa6eeg020X0dzGX_oz7LMxp1-2aINfvJBi5PwhJ-eB-tODbbB7aVstpdY7abasYJuTCBBPlN19Ozjj4tbqQm6fAlyyPA0d1uk3L7rSsI6fbLpL5HoxC2z3LaR-1j7rNVhH4XviRCLZ3yxY6n8ecw0xfQppohyxi4QuV_rKORvpzMX30g_ddUMIbdzSg5yJadLRlF5HesxAiiVxCNDcARswVEHyWhLQOe0dlBK2HGyXe-mNWnrKSMQmgqjbb2XExKktXmfF2Cg0h2pajHImYl6SUi2hnF8yFP_OEVscxUQ7YWzl-ecKecWbcBLIEuwF7EVKtsZvMVbHj4vp-wdRuH1ptp-V0u1a3eWRciSbzyHcpv6Nv_jSeQux_oM9sIbBlXu9u_aeJDCDqmLB20zgJL_2QbQE7F9zbBjahIjLjOuZQ4QfXkPz0XTeGVGa-8ErhrMzIHKdZkCy4x0h8E7jl5vqXIFSBO5djFPBHxBCmIGY1j5yVhSyEJDM5H_GLZT2xIBE4z0krwtwy5k6uwMdDKlm5gL9ISYo9i7SlPIuEazzbLgmo4CUErvdS8_CoCFTRTRcBC5_mo4nPuFeNOlXsnM5KxFd0cx5dyt3L4tY6owy0oku-0dArtwqVo6qq-QuN8kHccsw7A-1WDSg3gBmkxwDw2ErS7pg3H-K_uPXg1WD9cCri3FJpd1uFRmj6Ujaki5Dedw2ZF7tLq55ldm26izrjsJdc3RhtRIGinFeC9qWk7vNAeE-sLEQJqYRY1m8Uz2YQb3BElGWAyyuk-X4uUTrolKD-DAO61OzHhbi8gAV1aQFZclFeygqkvC2YHVQwZkFeWkTWoXcQMqawYKhawZ3w8muAcUN-CZu7Ujs1RbiyfzTOOfEKyk-wDBRVo4ZEanO0uAxZ8Ne8NP8l8lICLgIPcjKYDaVlrCLWiXnwpxBPo2hAJSVekn1_paFPA2mrwlnEaOhObqH3LynnjxAMTuv5t-qTqmtd-lyycADvUCgqtsrRQo4o-KSh6nP4dDOdiVAS9oa_7mko56f1MeUR04TqDfCJpB-oLTyEJM7rZDQRr33vBSU9CMGjFETobMYCb4nHQ8gYoWmAcVEJZTx-IFMagdZzPWIjtCZX3rvxlBmBAAUgSer1IMED23GnR8N5f5kw8EEvCbJyVUa7nRQQNScU--Hky_BWPXyYSDmLjhuN19fXwxmVEzFmb7BMHbpi2pgBCBQ-iJ59zg-QbaMP_86e-uqfYtRIOZ3oymLU0J9wnoY-6Kw7uYGGKq-jJ_Dhk5AswjZ8mX44GaGoCHozlFdsGp3NYWJdYvqxUhNJXInUIyb1KMlj0pKnx8Y05vj-t5hyH3u2mX97q6uzgQin2YYMWEHP4hKgOT7MZ-j6_u2tbulzmTBDcWk36-5MFCK-l3Zx8lIVX_sLrc8pdyOltx-4PPZgU5LEnGwYcfqIuqFlcYij-Uay6bF9fMFVPKOcWNek_8Y-kvto7k5glLv4EcvTuP_wUh9EXGBCxuhMBMSqr2qSKfrhBOxJwFdcPFJuL3TJqthqMOBQytQAzs8BTOA6-TPn4-QZKQfa3fUl3laq3oq2rogD3aEBnSaTZWFxJisZZg1lwvfwc-v4E3sl-PiRDGGFM7gVm3Z0qt3MeXXAohn1w-_ny1TA93DgivhKPtGQnEue2BQNvmOSerA0NLArogZOOa0zPF0z-jIfydB_VgmaCvCIWXqfuXbp7fdyrxJCEinvfJw8QoRQsVBHO3xUXlYUN8EslorhaX3qR-4fj_F4jCc0YAlwxUOni8vLi_OHm68XyQqahyhr_wji6SMePejf6ZIHPcxUlk-i-DHSj6f1rz57VYoMwNM-j9AuzuksYtkSpsJZojkHXAE3RXXtZ-c563ktCMycLt5YCCvuE-wk3dBnRr2y9g1KaYG4f8SMw8QNj0jMjPRW5BzWa70LNnhKnUqZueABkdEcbCzAQq5CuVFy0rrBExIXNBit_th3MVkr7nJc_jRVgV-yap2xv5N9lJmHOnMyMdCNZrA-_zGhk9YCr6qzJ6NXdasZPmAuNdquG83grLAiAnCTiUtGVcDpkwjUIIdJ0_c5rpjGnoUVNSMxM_wsJyxM0lITpzuIUSlJ4cQJ_cdYmqdxjqLAV6rUa_AQtpmhupRpsAHbCiLRUnnP4NA8jZmVLosZA1kRVO9_jf5LdtMFXZAUkwzu160FTkgragb7k-aCSaLib_9F-J6uqBimywpZUcCAHcfubFSZaHc2q3Wj3Tlewqbt2djfSasZ_kX6mNWs4aKzl1JMcFLtxgHn1m4cHiDxlHHItmYwXM1EFthhcQ6SFTrWgtPWosiR1D-25qCrNFvDVRFpa7SK_5ASM7CgcAHIaArmh4yDAThDFsyNkqyUWusDycK6Srz0UrjW0soc9QRPDjyLYoAm2cAI1vLrgmyxHKesFgq7E46XZQTfjeG7g91dmOGpTjyjgZey-7wuR1_0Q0nvCRkBT1XkG-Dh0a4-DNh0voaRWa-TRrqrU-U_3GclRUvYHuJ2-S8hpr-f1g-cI_2cFKOcpAAFOffAh54L1YhLJSHhfxCkZahdcVIOw-esGmbmEEdM3xTRJSGFyNWwkEu6mVbK5GpZQ3gt58fky6eb375c1K7CWE6eY_4v4BP9OyL3jMvat3k4jVzYhpCBiGG7LGs6tzgmeH6VfDijUXqTxucMmmpJApFQJZ_ekyVl3GNyHzLiHLYPm6uvrKP8u_M4BOtlTW9cmUeyFqeWVPGOid2sJdXLY3J1kP2vqQ4Zsj-BuFeDvRX3XR9pmrW_EwcdW__8DQH-iR03D9v__NhpHljN5k8_YK0kZKC8R3QJgaTnbUSPkgUD-6PzD2CqQJwlmU6zedBaEaqdTGD8k8STBDasEEsMiv_8o-WA6p3mT0QKMtWzm-Din1N0GWCDWLtVBHBWAK3mAehaALA-vpMBloFhgMDzLKJzXAz6eTvU0TCDlYUR-wcixoormbEwKZPnTcjRtotpnTyt1VxLbLXzTj9PL9-Skf8Xq6mEkCQFbQ8CLwlE2pW_Y-8oApi7MGo9P1KVJVUuuhPeEJ1AlCvwnKqdTsKkoGSksDdSOBspWhsp2hspOhspuhspehspjjZSpKfYRSSbvWptdquVnmapMuUijupOWYqdw_7worZaw68tlfBr5yEdQ7A6JhixaxDXxv7bMcnNjVsBgaHveczDk2Q9qnrFhDiDShFmh7op9Sger6W-SYe-LoupspdjpMbCFoYzXRvV5aDN1IuL1K318Xp4AP9zkbrbzEdqu_a3q325FDNtDEUQWFylhYovcRgxgou8zyLy6ssJeX_qQCCOQpJSwzoMaRPcPOArdR9ENYD_ItAAGUJAJdg36ZRXTZ2WarK6Op7lmywbm2zLIZn_03bLXortytlEebtmLzWlTkvqz0Q7ufaz3VUxNFlXVqkWLv5_-HkXftZN6NaaCZ0eFtXwQMgwf_F7FAUf0qmw4cNSHnIFasuIqOEP04IkpzulOnLFNDy2NKeGyyeaXEjiA-b-8cvwFlNZffgAA-wFt0_YpE-bG8WAxaFkCrE3Qc4EJPak_ziPIhzCKgyQdgWZZ5CkruLtCnhVbiDOFlaS0SudrYpubcNoB_MTHvYeeKw3qLMHgzp7MGgrHusMsqoMrnWj09mDR-x9WVNlvF0zPmVyJ3-smWydnTWwK3PYWaSzL_-39zAYrD1MD2sPerQqjoR9hRh71xnZ2oMDq68Zewuxzq722ztO4WoKePO0ILHDGNS5xS4c1k_s9s4cOvvqVmtfMab60Nzdj62d-7K9n0FVxfj-NOZM7iESOnsIKM6Ok7K1I97aj_-3XikrD9pWZcQ2WdSOXm3vGqv31C2tfQWXveXVW2-hKuDU9Ux759Bk76cP9rZS7GPD19rOpgXKKuX83PBtbef8PSUb7Z1Hwe5LXKdqMNg1eLwXqKs--gYqHkxSj43UoeQ3hnXHSJ9cqmNFdTFVBGP_KTlg1B-SI0aFz94Q6UvOchdo8_Wi_AVVN46kmN4JL1pcaG00CLnRt4sJ9wNGHhkXr1iyjBgjckIlecUfE_XNiqiG9P6YsKxA-5oWaF9FzD34GT6TH71ZRJ4EdEI8-6kGmADMfJwTltR4J_SFkQM8wgE5C1ZhdsaUXTK_59RlE8E9FiZGII958sdH0ju23WZzA2DpW08pzNmEWinHL5B29tdOzBJzf7okhbU3YPJfZMswG03LDhcq6bc4vKgEU-XOBaLXMtNPs-I2_pkQFjJvpK7w4tXtEePj3B3pdgkbKzsm6717vCaRdXpZVPWOwDG26tLeUadER1TSEEfWqhinzCgpK2XkCnVTAjoreneR3Sgh-Tqr4FyVvvOzcwMyXd1SQMc66h2ZMZH_5PPPY3W_CpRUl8TKKrn83dtKIz-7hZnJalqtIi9OYB0wOPGkkUVvfVtFffqldtJY_VtW_wOHlNt9

The 'Your Spells are disabled' mod found on the Gruthkul's Pelt unique
chest armor currently prevents curse on hit mods from applying. This is
due to the 'chance to Curse Enemies with X on Hit' being implemented in
POB as a simple granted skill without making the distinction between
generic granted skills and on hit (application) skills (curses). This
solution isn't the prettiest but i'd argue it's the most sane given what
information is available to the ModStore.
@Paliak Paliak added the bug: behaviour Behavioral differences label Feb 23, 2025
@LocalIdentity LocalIdentity merged commit f9da201 into PathOfBuildingCommunity:dev Mar 5, 2025
2 checks passed
@Paliak Paliak deleted the issue-8484 branch March 6, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
2 participants