Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "minions recover #% life on block" #8527

Merged

Conversation

Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Feb 26, 2025

Description of the problem being solved:

The tree node "Decay Ward" and the unique helm "Skullhead" had the mod "minions recover #% of their life when they block". Functions now, I did notice though that Life on Block rounds up though. I'm assuming it's supposed to, but seemed odd seeing 31.02 rounding up to 32.

Steps taken to verify a working solution:

  • Checked both Skeletons and Zombies, they gain Life On Block and their time before death changes too, as one would expect.

Link to a build that showcases this PR:

https://pobb.in/EhLcb6xiA89Y

After screenshot:

image
image
image

@Paliak Paliak added the enhancement New feature, calculation, or mod label Mar 2, 2025
@LocalIdentity LocalIdentity merged commit 294ba71 into PathOfBuildingCommunity:dev Mar 5, 2025
@Blitz54 Blitz54 deleted the minion-life-on-block branch March 5, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants