Remove Royale mods from craft menu and exporter #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8532
Description of the problem being solved:
Royale mods (I'm assuming from the april fools thing?) were removed in #4225 but brought back by #8516.
https://github.com/Blitz54/PathOfBuilding/blob/99907c0602a747bbe267333f6a03b8e52d40f88d/src/Export/Scripts/mods.lua#L140
This line was added by #4225, removing it appears to be fine when exporting. I assume the mods use to have that AuraFlag but no longer do. Not sure if it will be used for future mods or not.