Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gem-lined Cap Ascendancy Notable not applying #8575

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Mar 14, 2025

Closes #8558

Description of the problem being solved:

Parsing of the Gem-lined Cap Ascendancy Notable mod "+3 to Level on all non-Exceptional Support Gems" was incorrect due to faulty handling of the hyphen causing "non-exceptional" to be split into two keywords: "non" and "exceptional". This caused the mod to not apply as there does not exist a gem tag called "non". This commit fixes this by improving handling of non space characters in the keyword string and implementing handling for the negation part in "non-exceptional" inside of calcLib.gemIsType function.

Link to a build that showcases this PR:

eNq1W1932rgSf24_hQ_PaQBjG9hDuoeEpMk5oWEhbe996lFsAdrKFmvLSdhPf0eSbQxFxsa-fUjBmt_802g0GovRn-8-NV5xGBEWXLW6l52WgQOXeSRYXbW-Pd99GrT-_PxxNEN8_bS8jgkVI58_fhjJzwbFr5gCrmVwFK4w_55y6v0EThsU8DVmwRT9zcIvzLtqfWUBbhkvKPAIT7-5FEXRV-Tjq9YkxpREvGWgyMWBd7MbGYfwnLkhgkF3jULkchw-CunjmLMp84CGhzGw8xEJFsz9hfmXkMUbqdwrwW-K5mE6e5o_51QjQV41sOzDaEbRFocLjrgRwR8QDg5CKzxBPvwFbojGwMq0Loedvt1qF4Ku4zDi1ZCLDcZeRgxzYuooZyG-XS6xy8krvgkJv1mjwN3J6ehwVWmnMeVkQwkOc2pp9b__jbmjI31mHNHJbLFzjX1pdWzHLgYwflrvH4Svryl4sgp7AXpYBYTjqqgZIxELzjElj9HPQkwprLxStHMc4fAVcbKvj543819IUM1R4xCjp6UKvjnySBxNMQ9xtGNwqY3aKQrQDYt2c9gdFJHOcAjJgO8hOicAC-wyyB_7Qi57Tgk5x9FagY9kictTVrIlAVTV5jw7bhdl6SozPk-hOWTMcpQLFtOSlHyXwMyefv38kyfsdrs6ygl-L8HvIchFoVUgNU_oDPRCX5lY26fNlRnm9n6WUfYGl4OhORxYttmxO1qFZ-ttRFxEp-id-LEP-fwZ_cI7gU5XH3-rNQ8gUemgvb4OekdCXB11w6h3BmqNWKSFFWQjEtxD7TJ23RgqkG0GsZyiBVnCb7Dlu38I2ofALbfKvwWhTPO5SqFoWpZ4DmtPlCQvFJdE7EQkK3gXxZ1OsagVDhJ523LmPGLsrr-Af-eI43Jpfuf9fqFbBW0ptwrCI27Vs98HVHCSAGqcdFm4F1Z0022Aw9V2sSaYetWoU8Vu0KZEWhVuzqNLuXtfXKWIyUMruuQHCr1ym09VnV5RlM_KXafYXYq8XGBiqGMB4OGyRfssZH-LYwGtBhuHPovDkhOuiEsZkG4o6hw0x17sltvBstPNNYUjXVkzMhToSWkl6Jhz5P6aMG9V2mlSSCXEvn6LeLOBHCKioSwDsVdClU9yNc8npwT1E4RyqRUtttXyAnbUpQVkhUJ5KQeQ8raIzb6CMTvy0iKyCZ1CsvBhE5BH-CnLneK1kwMHu1KnNElY8rQ4Y2-g-Vq0ZKJq1FAU7QohrSohDv7dlua_R15KwG3gQYEFS6G0jEPEMTHPxIdEGkUTxJHhJVX0dxQSFHBT9okijEJ3_QhTf4cofYFMcNXKP5XfZG_pjlCOwwk8E0KFYoccu-mkj9qyVyY-PfgbFnIDv4v_Zijk26vWEtEIK0L5BPhEnATy-A75iNKWsVizt7H3KiQ9M0ajFGSgzQYH3h6P5xBjA6XZxRVKSOPFF8NHEWi9VeEaCWtyjbYHT_ogYKDAVcu2ul3rwhoMLOfCgY_9C9NyOv0LuzMcOBc9u2OaF71ef2hfWM4ADtbgJXG2Q-F2vM8yIGABB61yvUHT_omE_wK5ZbspqSVV_TD6Nn-UHz6sOd9Ef7Tbb29vlxvE12yJ32FPu3SZ394ACIz8FP0ilH4SAtpj-He9-uv6mn8lr1E_Ns3xkkwdcwjPJeN2ynmkOoRRW30TCz0kYLcKlLZwlpw54U3x4SvjOBJj4mH6ZbQQoiOIiJB_wX50vYXFeSdqkoOeSjIdgnqBuYq0PCZtXXp4iWIqnv8VI0pEdHTyTx9VtzVgoZ8dzoAVRIfYQxTH5-1GTN_48VGNjClPmAlxaaiokEgUMoiXhknyUDZRxzutbxB1I6k3CVwae3BMSfJWFooUvQjdRPtYHDG8fDs2xykT9GEE-iTEXyh7QdRMIXJGxVrYiU36zCa4Y4V9EStTzJEHC7n9wMGutjCuLSXAp4VPVCkoF6KgTp5Izrnv_-TcnEmVApMRQTtR_m_tKdtNlT0w12VxoDgEyE9WoBLWPmV2YmOv2MRsoseeR0SOQFSGxb65iuoW0s2b6Nnu7D4YyDugSZNTAWWNPjWxeauxJwqaXUv90OrfSA6t_43g_-UFKcgQkoxEVJJvVKQmuSZZhTLfqIwiPsrYlxQPwSbmkutVyyeR-_MlXi7F2wywjIfyRc3t3d3tzfPD99tkp8tDpPU_g9h_EROu_t_VIwssK3Ejil8i9fGq9Z3gN6nIBKaC0EgYRynaRDjbamTKSDSngCvgJqnuSfYO5DivHYGe0-07DmFnXMERzg0J1uqVjZ9QSgkUxztRGei4iZcNekbqvHAD-6o6fmo8Jd_o6LmIdyxac8RgARZqCkS1kpPRE57gYtOAkCVL4oqiqnjKxRajqAr8krXItPOdHHb0POTbGx0DNagHq_cxOnQyWuBV-RJI61U1qodPsIu0tqtBPTjraLAA3KTjklEVcPrKAhnksGjGhIqDiXZmbynOSPQMn_gah0n5qOM0hRyVkhQunJC8xFy_jHMUBb6S_VWNh8SYHqp6iBobxFhBJtrrq2kcmqfRs1L9KG0iK4KqQ6rWf8mRt2AKkm6Pxv1qtMAJacNLY38yXLBIZP4dvzLiqbaHZrkckBUlDKjq67ORvZz6bA6bO_U53sFB6Zd2vpNRPfwbJ6K0OcJFlTClmIhFVY-DWFv1ODzDKYTHIT6bwfywEtlh58U1SNaQOApOR4syR9KnOJuD6qacDZ-pwv9MtMz_UBdjsKBwA8hoCtYHj4MJOIMXrI2SrKRaxxPJzrpKvNRWeNTSyhzVAk9eMhblAEVyghHs5fcF1WI5TlnD8h4jKi6vMFqP4W8vU-swEy9d4g0KvJTd07EafTcPJb3HeAQ8ZTNuIt7t1PVhgP3tEUZ6vUbt9FQn23TinJU0Fxc8FL2Tfxnz_3vV-mR2-71Lu2N17KFpD3tqIOn-DJOODxTgEwLTGMrwS8UKwv8Ah75lXfadoW3ajjl0VAd0JE_USTdKfM6aUXp-cYTVpY0fGG1YIBG5FlLCpYBsv7lEGTegcvZnL9_mj8JidUaFo_WrWGViSJy8O-lBWQdQYoxuBcg1g_k3xi_bKELUUP0_w67CAFN-iDcr4OWuZPTOsNJYvKHNoWjrHEY1zE94mA3wOG6Q04BBTgMGncXjmEG1o7PXgEfMpqypEm_3GLZPXssfRxabU1sDszKH2iJ7TfnfbiAYug0sj24DelgVI6GpFGPWXZFWAw6svmc0lmJ7de03ay7hagp4W0N1IerEoKot6nA4vrDt2hycpqa121SOqR6a9f1o1Z5Lu5mgqmL82I8p5g1kwl4DCaVXc1FaNfHdZvx_9k5ZOWityohzqqiaXrXr5uqGpsVqKrk0VleffYSqgJuTYFVpCo-nJrOZOWhsp2jiwGedZ1NV59ff4xsqNuzaitTf4pyqyaBu8vhd4KidNHvUXboQeXghe1c_sLiYGakGl2wxyfsLLFiSVdJsUl-SdpPEZ08MTjjFucsW-X7RjCIXrxn1cJgoi0XTLfmBZHqXod_JbNQA9q6AprDeKVR24TS9upAiTdPqnpKY-4VlCrNPYPK3ejPMSdPgyRn65a-_VIAlV41SxMDS0_vZb0bFzyNxiL2FvCoh7sksMF3m7qLYJWys7Jhs9maiHZ1NellU9YkQMXbo0sHQOQHL3qJm3uh0rV6J6DoU1SsTKWV9sXCZ7ErDhEW_XRrSSkiu9zNK5yjI69Y_pVu6RaQApzscDPWYiKwIfVrKd1mgpHwhV1bJ_d8iVF40pT24hkSqceConaU_9VZAfvv8cdQ-_J39_wAZrl_p

Parsing of the Gem-lined Cap Ascendancy Notable mod "+3 to Level on all non-Exceptional Support Gems" was incorrect due to faulty handling of the hyphen causing "non-exceptional" to be split into two keywords: "non" and "exceptional". This caused the mod to not apply as there does not exist a gem tag called "non". This commit fixes this by improving handling of non space characters in the keyword string and implementing handling for the negation part in "non-exceptional" inside of calcLib.gemIsType function.
@Paliak Paliak added the bug: accuracy Wording differences label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gem-Lined Cap showing as implemented in PoB but has no effect
1 participant