Remove isset call when checking for existing cached placeholder image#212
Open
mlyndaker wants to merge 1 commit intoPatreon:masterfrom
Open
Remove isset call when checking for existing cached placeholder image#212mlyndaker wants to merge 1 commit intoPatreon:masterfrom
mlyndaker wants to merge 1 commit intoPatreon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protected image placeholder is always generated on each request instead of using the previously cached file.
In patreon_protect.php, the file_exists check for the previously generated file has additional call to isset($go). This will always return false, forcing the image to be regenerated each time rather than reusing the existing cached file.