Scale to percentage #377
Scale to percentage #377
Conversation
…percentage instead of a decimal scale. Styles the open pdf message a little bit more. Changes the styling of the scale message (see if you like it or not, it takes up a bit more screen real estate)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I am going to close the PR temporarily after talking with Sasha. Will reopen if I get to a good place! |
…ion over DM. Does not modify the input value to percentage, but instead uses the new proposed styling to add both units to the display bar
|
I ended up removing the conversion to percentage in the actual scaling form, but since I changed the styling for showing scale, there is more room to show scale in both units (decimal scale and percent scale). This keeps the percentage zoom folks from asking questions but also (hopefully) prevents questions from those who are confused on decimal. |
…ms must be different locally
…percentage conversion in scale-menu. Was causing user input to not work correctly
|
Sorry for taking so long to get back to you @hluedeke ! The whole family has been battling a nasty virus the last few days so I haven't had any time for PP. I mostly agree with your changes! The scale factor is definitely confusing for folks. As @sashasewist mentioned, the reasoning for not using percentage is that it's too likely that people coming from Adobe will be confused and input their percentage. I like the switch to .05 step. I'm almost thinking maybe even lower to a .01 step since the people who have requested scaling all seem to be doing tiny scale changes. What do you think? Also, with the percentage now being shown in the banner, the 1% step may be easier to understand. Thank you for all the styling cleanup! It's much needed. The open PDF message is much prettier and easier to understand, thank you! The size and subtlety of the scale banner scares me a bit. I've read about people ignoring the calibration warning and still cutting even though its right in the middle of the screen. I think it makes sense to make it a banner and also maybe format the magnify/zoom out messages in the same way but I think it needs to be obnoxious and in people's faces. I'm not sure how to make a sufficiently eye catching banner but I'd like to see one because my current styling looks bonkers, lol. Thank you again! The code and front end always look cleaner after you send a PR! |
Pull Request Checklist
yarn buildto ensure that the project builds successfully.CHANGELOG.mdwith the necessary changes made in this pull request.Description
This PR updates the scale menu to use percentages instead of decimal for scale. Percentage zoom is a much more familiar for those switching from Adobe.
Related Issues
#376
TODO
Review styling changes. You may disagree with them - would like feedback!