-
Notifications
You must be signed in to change notification settings - Fork 471
add net5 target framework #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What a reason to target raw, clumsy .NET 5 if it's not even ready? No WinForms, no WPF... WHERE you suppose to run FCTB?? Not saying you break project file in favor of 3 developers who use .NET 5 (against thousands who sit on FW 4.8). |
Meanwhile I have no issues with creating a new .NET 5 WinForms project and installing FCTB from Nuget. |
Using NU1701 Package 'FCTB 2.16.24' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net5.0-windows7.0'. This package may not be fully compatible with your project. It might be worth noting the package doesn't even follow the guideline to specify a TFM for the dll in lib folder. Apparently no one dares to update this project though!? However, having created this PR I see my duty fulfilled in regards of the oh-so-awesome LGPLv3 license terms... |
Would be nice to get rid of the warning when targeting net5. Can someone please approve this PR? |
@6bee This PR will likely not be accepted as there is another PR that changes the component to build with .NET 7, and as is stated above, the control works perfectly with .NET 5 already and only displays a warning to the user. The component will likely not be uplifted to newer versions of .NET for some time. |
This PR is about adding target framework net5.0 and to generate nuget package on release build.