Quadratic-Damped PID and Controller Manager #59
Conversation
Py-mon
changed the title
There was a problem hiding this comment.
This is redundant, no? Why do the Coefficients need themselves and the controller?
There was a problem hiding this comment.
there isnt much point for the coefficents to be apart of the Controller interface, they can exist seperate
There was a problem hiding this comment.
Agreed. A controller does not inherently require anything about coefficients. That is an implementation detail.
There was a problem hiding this comment.
there isnt much point for the coefficents to be apart of the Controller interface, they can exist seperate
The controller manager needs the generics in order for the dual controller to work.
| 0.015); | ||
| public PIDFCoefficients coefficientsTranslationalPIDF = new PIDFCoefficients(0.1,0, | ||
| 0,0.015); | ||
| // 0.5, |
There was a problem hiding this comment.
can you undo this for consistency
There was a problem hiding this comment.
Just make this an interface, do not need any of the bounded Type Parameters
There was a problem hiding this comment.
Just make this an interface, do not need any of the bounded Type Parameters
I’m pretty sure the type parameters are required for the controller manager.
3 participants
not finished yet; just for review.