Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates/standards and small fixes #1091

Closed
wants to merge 7 commits into from

Conversation

AmintorDusko
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@AmintorDusko AmintorDusko added do not merge Do not merge PR until this label is removed ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request draft Indicates that the PR is still in draft mode, but needs CIs. labels Mar 14, 2025
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (1c22831) to head (78d799e).

❗ There is a different number of reports uploaded between BASE (1c22831) and HEAD (78d799e). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (1c22831) HEAD (78d799e)
8 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1091       +/-   ##
===========================================
- Coverage   95.76%   56.72%   -39.05%     
===========================================
  Files         237       29      -208     
  Lines       40463     2819    -37644     
===========================================
- Hits        38751     1599    -37152     
+ Misses       1712     1220      -492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomlqc
Copy link
Contributor

tomlqc commented Mar 14, 2025

@AmintorDusko Did you get compiler warnings about the 1U issue?

@AmintorDusko
Copy link
Contributor Author

@AmintorDusko Did you get compiler warnings about the 1U issue?

Yes, but only for some of them.

@maliasadi
Copy link
Member

Yes, but only for some of them.

How come? Could we check and capture them with clang-tidy?

@AmintorDusko
Copy link
Contributor Author

Yes, but only for some of them.

How come? Could we check and capture them with clang-tidy?

We are already checking, but not all of them are being caught. This is all the information I can provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request do not merge Do not merge PR until this label is removed draft Indicates that the PR is still in draft mode, but needs CIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants