-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates/standards and small fixes #1091
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
===========================================
- Coverage 95.76% 56.72% -39.05%
===========================================
Files 237 29 -208
Lines 40463 2819 -37644
===========================================
- Hits 38751 1599 -37152
+ Misses 1712 1220 -492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@AmintorDusko Did you get compiler warnings about the 1U issue? |
Yes, but only for some of them. |
How come? Could we check and capture them with clang-tidy? |
We are already checking, but not all of them are being caught. This is all the information I can provide. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: