Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dispensable C++ source code in Lightning wheels #1098

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Mar 17, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Remove dispensable C++ source code in Lightning wheels. 🚧 Testing is still in progress! 🚧

Description of the Change:

  • Remove core src files in Lightning wheels

Benefits:

  • Fix the issue with installing PennyLane with Lightning-Qubit on older versions of Windows that has a maximum limit on the length of file paths.
  • Cleaner wheels src directory by removing unneeded C++ src code.

Possible Drawbacks:

Related GitHub Issues:
[sc-82977]
[sc-82978]

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Mar 17, 2025
@maliasadi maliasadi marked this pull request as ready for review March 17, 2025 21:12
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.80%. Comparing base (2878283) to head (b2168d6).

❗ There is a different number of reports uploaded between BASE (2878283) and HEAD (b2168d6). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (2878283) HEAD (b2168d6)
8 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1098       +/-   ##
===========================================
- Coverage   96.07%   27.80%   -68.28%     
===========================================
  Files         235       28      -207     
  Lines       39745     2658    -37087     
===========================================
- Hits        38186      739    -37447     
- Misses       1559     1919      +360     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants