-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI test requirements.txt #1105
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
+ Coverage 97.97% 99.11% +1.13%
==========================================
Files 238 148 -90
Lines 41252 22979 -18273
==========================================
- Hits 40416 22775 -17641
+ Misses 836 204 -632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Context:
Follow up to ##1084.
After merging to master, it was found that
arm-gpu
wheel building tests were failing (see here).Description of the Change:
Update CIs to use requirements-tests.txt instead of requirements-dev.txt.
Also install jax for CI tests.
Benefits:
CI (arm+cuda) is 💚
no longer require installing unnecessary packages.
Possible Drawbacks:
Jax version is explicitly pinned in the CI test
[sc-85859]
[sc-87026]