Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test requirements.txt #1105

Merged
merged 22 commits into from
Mar 24, 2025
Merged

Update CI test requirements.txt #1105

merged 22 commits into from
Mar 24, 2025

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Mar 20, 2025

Context:

Follow up to ##1084.

After merging to master, it was found that arm-gpu wheel building tests were failing (see here).

Description of the Change:
Update CIs to use requirements-tests.txt instead of requirements-dev.txt.
Also install jax for CI tests.

Benefits:
CI (arm+cuda) is 💚
no longer require installing unnecessary packages.

Possible Drawbacks:
Jax version is explicitly pinned in the CI test

[sc-85859]
[sc-87026]

@andrijapau andrijapau added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Mar 20, 2025
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (e34523f) to head (7aaf6c0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   97.97%   99.11%   +1.13%     
==========================================
  Files         238      148      -90     
  Lines       41252    22979   -18273     
==========================================
- Hits        40416    22775   -17641     
+ Misses        836      204     -632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josephleekl josephleekl added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Mar 20, 2025
@josephleekl josephleekl changed the title Fix arm-gpu CI Update CI test requirements.txt Mar 20, 2025
@josephleekl josephleekl requested a review from maliasadi March 21, 2025 22:36
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tomlqc tomlqc self-requested a review March 24, 2025 12:56
@josephleekl josephleekl merged commit 888e226 into master Mar 24, 2025
102 checks passed
@josephleekl josephleekl deleted the fix-arm-gpu-ci branch March 24, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants