-
Notifications
You must be signed in to change notification settings - Fork 215
Daily qml builds with RC environment #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
runora95
wants to merge
3
commits into
master
Choose a base branch
from
sc-101692-dailyrcbuild
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| name: Build Daily RC Demos | ||
| on: | ||
| schedule: | ||
| - cron: '0 11 * * 1-5' # Runs weekdays 6 am ET | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| check-for-rc-branches: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| branch_exists: ${{ steps.check-rc-branches.outputs.branch_exists }} | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: PennyLaneAI/pennylane | ||
|
|
||
| - name: Install latest setuptools | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install --upgrade setuptools packaging | ||
|
|
||
| - name: Check for RC branches | ||
| id: check-rc-branches | ||
| run: | | ||
| VERSION=$(python setup.py --version) | ||
| echo "Current version: $VERSION" | ||
| IFS=. read MAJ MIN PAT <<< "${VERSION%-dev[0-9]*}" | ||
| RC_BRANCH="v${MAJ}.$((MIN-2)).${PAT}-rc0" | ||
| if git ls-remote --exit-code origin "refs/heads/$RC_BRANCH"; then | ||
| echo "branch_exists=true" >> $GITHUB_OUTPUT | ||
| echo "rc_branch=$RC_BRANCH" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "branch_exists=false" >> $GITHUB_OUTPUT | ||
| echo "No RC branch found." | ||
| fi | ||
|
|
||
| build-demos-with-rc-branches: | ||
| runs-on: ubuntu-latest | ||
| needs: check-for-rc-branches | ||
| if: needs.check-for-rc-branches.outputs.branch_exists == 'true' | ||
| outputs: | ||
| pennylane-version: ${{ steps.setup-rc-versions.outputs.pennylane-version }} | ||
| lightning-version: ${{ steps.setup-rc-versions.outputs.lightning-version }} | ||
| catalyst-version: ${{ steps.setup-rc-versions.outputs.catalyst-version }} | ||
| rc-build-branch: ${{ steps.setup-rc-versions.outputs.rc-build-branch }} | ||
| steps: | ||
| - name: Checkout QML repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11' | ||
|
|
||
| - name: Set up rc versions | ||
| id: setup-rc-versions | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| rc_build_branch=rc-daily-build-$(date +'%Y-%m-%d-%H%M%S') | ||
| git checkout -b $rc_build_branch | ||
| python -m pip index versions pennylane 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || true | ||
| pennylane_version=$(python -m pip index versions pennylane 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || true) | ||
| lightning_version=$(python -m pip index versions pennylane-lightning 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 ||true ) | ||
| catalyst_version=$(python -m pip index versions pennylane-catalyst 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1 || true) | ||
| echo "lightning-version=$lightning_version" >> $GITHUB_OUTPUT | ||
| echo "catalyst-version=$catalyst_version" >> $GITHUB_OUTPUT | ||
| echo "pennylane-version=$pennylane_version" >> $GITHUB_OUTPUT | ||
| echo "rc-build-branch=$rc_build_branch" >> $GITHUB_OUTPUT | ||
| echo "PennyLane version: $pennylane_version, PennyLane-Lightning version: $lightning_version, PennyLane-Catalyst version: $catalyst_version" | ||
|
|
||
| - name: Update demo versions | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| sed -i -E "s#git\+https://github.com/PennyLaneAI/pennylane.git\#egg=pennylane\",#pennylane<=${{ steps.setup-rc-versions.outputs.pennylane-version }}\",\\n\\t\\t\\t\"—extra-index-url\",\\n\\t\\t\\t\"https://test.pypi.org/simple/\",\\n\\t\\t\\tpre=True,#" lib/qml/lib/demo.py | ||
| sed -i "s/PennyLane-Lightning/pennylane-lightning<=${{ steps.setup-rc-versions.outputs.lightning-version }}/" lib/qml/lib/demo.py | ||
| sed -i "s/PennyLane-Catalyst/pennylane-catalyst<=${{ steps.setup-rc-versions.outputs.catalyst-version }}/" lib/qml/lib/demo.py | ||
| git commit -am "Set up RC versions for demo builds" | ||
| git push --set-upstream origin ${{ steps.setup-rc-versions.outputs.rc-build-branch }} | ||
|
|
||
| build-demos: | ||
| needs: build-demos-with-rc-branches | ||
| uses: ./.github/workflows/v2-build-demos.yml | ||
| with: | ||
| ref: '${{ needs.build-demos-with-rc-branches.outputs.rc-build-branch }}' | ||
| demo-names: '' | ||
| execute: true | ||
| dev: false | ||
| save-artifact: true | ||
| artifact-name: 'demo-build-use-rc' | ||
| artifact-retention: 10 | ||
| keep-going: false | ||
| quiet: false | ||
| batch_size: 10 | ||
|
|
||
| cleanup: | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - build-demos | ||
| - build-demos-with-rc-branches | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Cleanup branch | ||
| run: | | ||
| echo "Cleaning up branch '${{ needs.build-demos-with-rc-branches.outputs.rc-build-branch }}'" | ||
| git push origin --delete '${{ needs.build-demos-with-rc-branches.outputs.rc-build-branch }}'|| true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the logic here, but I don't think manipulating the qml build tool files directly with sed in an Action is the right approach. I would prefer instead to add new command line argument(s) to the tool. We could even make this more general so you can build any version for PLC by passing in the arguments. We can then keep the logic that parses out the RC branches here in the Action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense