Skip to content

ENH: harden transformToWorld of exported models #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ENH: harden transformToWorld of exported models #15

wants to merge 2 commits into from

Conversation

@mauigna06
Copy link
Contributor

Related #14

lassoan
lassoan reviewed Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this will be good, just please address the inline comment.

lassoan
lassoan reviewed Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be good, I just added a few nitpicky comments.

You can make changes in Slicer using the web interface. A pull request is automatically created and tests are executed on it.

OpenAnatomyExport/OpenAnatomyExport.py
transformer.SetTransform(ras2lpsTransform)
transformer.SetInputConnection(outputModelNode.GetPolyDataConnection())
transformOutputModelToWorldRAS = vtk.vtkGeneralTransform()
transformOutputModelToWorldRAS.PostMultiply()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to come after the slicer.vtkMRMLTransformNode.GetTransformBetweenNodes(inputModelNode.GetParentTransformNode() call.

OpenAnatomyExport/OpenAnatomyExport.py
transformOutputModelToWorldRAS.PostMultiply()
slicer.vtkMRMLTransformNode.GetTransformBetweenNodes(inputModelNode.GetParentTransformNode(), None, transformOutputModelToWorldRAS)

transformOutputModelToWorldLPS = transformOutputModelToWorldRAS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really explain things. You could create a new vtkGeneralTransform instead just assigning a new name but that would be a bit overcomplicated,l. Probably using just the transformOutputModelToWorldLPS name and a good comment would be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lassoan lassoan lassoan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mauigna06 @lassoan