Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe: clean up some tests #23120

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Safe: clean up some tests #23120

merged 1 commit into from
Mar 20, 2025

Conversation

mauke
Copy link
Contributor

@mauke mauke commented Mar 15, 2025

  • BEGIN { require Config; Config->import; } -> use Config;
  • new Safe -> Safe->new
  • more use of Test::More skip_all instead of manual print/exit

  • This set of changes does not require a perldelta entry.

Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but the fact that different changes are being made in different files makes me think I'm at risk of missing something. So additional eyeballs requested.

@mauke
Copy link
Contributor Author

mauke commented Mar 15, 2025

Good point. I fixed the condition in t/safenamedcap.t.

@tonycoz
Copy link
Contributor

tonycoz commented Mar 19, 2025

This should bump $Safe::VERSION, otherwise it's good.

- `BEGIN { require Config; Config->import; }` -> `use Config;`
- `new Safe` -> `Safe->new`
- more use of Test::More skip_all instead of manual print/exit
@mauke
Copy link
Contributor Author

mauke commented Mar 20, 2025

Done.

@mauke mauke merged commit dd8625e into Perl:blead Mar 20, 2025
33 checks passed
@mauke mauke deleted the gumbo-6 branch March 20, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants