op.c toke.c add gv_override_pvs() change manual string lit. lens to macros #23428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulk88
commented
Jul 11, 2025
bulk88
commented
- gv_override() is not exported from libperl on any OS
- gv_overridepvs() is harder to read, gv_overrides() is an obfuscated name
- This set of changes does not require a perldelta entry.
khwilliamson
requested changes
Jul 15, 2025
…acros - manually counted string lengths is an anti-pattern, even if the lengths are correct, there is still a thought of "what if a mistake happened" - better tools exist in the Perl C API, this commit switches to using them - gv_override() is not exported from libperl on any OS - gv_overridepvs() is harder to read, gv_overrides() is an obfuscated name
|
repushed with a new commit title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.