perfer X-Forwarded-Proto to prevent users lying #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Forwarded-Proto should be the preferred header to used to check if the front end connection was HTTPS. Proto is the de facto standard for this, and is recommended in the deployment documentation. If the -Protocol header is checked first, that means most setups that only add a -Proto header will pass through a user provided -Protocol header, allowing users to lie about the protocol used. Ideally this would only check one header, and the reverse proxy would be required to send that header. Leaving this with the fallback behavior for now for backwards compatibility.
|
This looks reasonable to me! See also #590 for a very old, much more in-depth consideration of behind-proxy stuff - but I think this has value in being merged now as a quick improvement. Mozilla agree - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto describes -Proto as "a de-facto standard header", and mentions -Protocol under "Other non-standard forms", so that's enough as far as I'm concerned to accept that, yes, we should look for -Proto first, as it's the most likely one. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Forwarded-Proto should be the preferred header to used to check if the
front end connection was HTTPS. Proto is the de facto standard for
this, and is recommended in the deployment documentation.
If the -Protocol header is checked first, that means most setups that
only add a -Proto header will pass through a user provided -Protocol
header, allowing users to lie about the protocol used.
Ideally this would only check one header, and the reverse proxy would be
required to send that header. Leaving this with the fallback behavior
for now for backwards compatibility.