Many changes to the website, mostly involving changing links D1 -> D2 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. If I merge the change it will be automatically deployed. So I am waiting till you tell it is ok. |
to Dancer2. Since the Twitter JSON API is gone, removed the last tweet from the bottom of the page. Instead, I put a link to Dancer's Twitter account in the footer. Seeing "Unavailable" in the footer didn't look so hot. Since other links use MetaCPAN instead of search.cpan.org, I changed the cpanm link to use MetaCPAN too. Please note: the D2 deployment link will not work until a new release of D2 happens - Dancer::Deployment gets renamed to Dancer2::Manual::Deployment. So this change shouldn't get deployed until that happens :)
cromedome
force-pushed
the
doc/dancer2-update
branch
from
53c0435 to
c576df9
Compare
|
OK, once we push the next release of Dancer2, I will ping you :) Thanks! |
|
As far as I am concerned, this is good to go. All the changes I was waiting on went out the door with the latest Dancer2 release @xsawyerx made. Not sure if anyone else needs to green-light this, but it's ready to go when you are. |
|
Sorry for my previous comment, ignore the email if you received it ;) It looks fine with me. Let's merge it. |
sukria
added a commit
that referenced
this pull request
Oct 26, 2015
Many changes to the website, mostly involving changing links D1 -> D2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, the Twitter JSON API is gone, removed the last tweet from the
bottom of the page. Instead, I put a link to Dancer's Twitter account in
the footer. Seeing "Unavailable" in the footer didn't look so hot.
Since other links use MetaCPAN instead of search.cpan.org, I changed the
cpanm link to use MetaCPAN too.
Please note: the D2 deployment link will not work until a new release of
D2 happens - Dancer::Deployment gets renamed to
Dancer2::Manual::Deployment. So this change shouldn't get deployed until
that happens :)