Fix broken download button on landing page #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we even need the version-fetching at all, if it's not going in the download button any more? |
MetaCPAN API v0 has been deprecated and shut down, so we could never fill in the download information for the button. The response is slightly different in v1 than v0, so adjusted accordingly. The version for Dancer2 doesn't fit as cleanly as the version for Dancer, so I removed it (and version handling) entirely.
cromedome
force-pushed
the
fix-download-link
branch
from
14c611e to
1d39789
Compare
Good point. Updated the PR. Only tracking the download URL now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaCPAN API v0 has been deprecated and shut down, so we could never fill in the download information for the button. The response is slightly different in v1 than v0, so adjusted accordingly - there's no reason to keep short_version and version, so I removed short_version.
The version for Dancer2 doesn't fit as cleanly as the version for Dancer, so I removed it from the button display entirely.