Enable CodeCov #768
Merged
Enable CodeCov #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
slifty
commented
Jan 3, 2026
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| slug: PermanentOrg/sftp-service | ||
| fail_ci_if_error: true |
Collaborator
Author
There was a problem hiding this comment.
This is something we might want to consider adding to our other codecov configs -- without it CI can still pass even if we don't successfully upload coverage to CodeCov
slifty
force-pushed
the
33-update-test-ci
branch
from
1419fad to
b67e78f
Compare
slifty
force-pushed
the
33-update-test-ci
branch
from
b67e78f to
a43390b
Compare
slifty
force-pushed
the
33-update-test-ci
branch
from
a43390b to
bd24340
Compare
slifty
force-pushed
the
33-update-test-ci
branch
from
bd24340 to
c63bc5f
Compare
liam-lloyd
approved these changes
Jan 5, 2026
slifty
force-pushed
the
33-update-test-ci
branch
from
c63bc5f to
755e7c9
Compare
Now that we're starting to write tests we should follow practices of our other repositories and use CodeCov. In the past we've run tests twice (once with coverage and once without) due to an upstream issue[1], however I don't think we need to do this since we don't use runInBand and also that issue may now be fixed. Issue #33 We need tests 1. kulshekhar/ts-jest#4193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up CI to use codecov (and adds a ci version of the test command to run with coverage)
In the past this has sometimes resulted in a CI that won't fail if tests fail, due to an upstream bug -- I believe that isn't the case here, though once I open the PR and it works I'll add a temporary commit with a failing test to ensure CI fails.
Related to #33
This should be merged after #764