Skip to content

Improve resource path handling and error reporting #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve resource path handling and error reporting #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions permuta/bisc/bisc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ def auto_bisc(prop):
print("Attempting to read perms from permsets")
good_entry = None
bad_entry = None
with os.scandir("../resources/bisc") as entries:
bisc_dir = os.path.join(os.path.dirname(__file__), "..", "resources", "bisc")
bisc_dir = os.path.abspath(bisc_dir)

with os.scandir(bisc_dir) as entries:
for i, entry in enumerate(entries):
en = entry.name[:-5]
spl = en.split("_")
Expand All @@ -125,8 +128,8 @@ def auto_bisc(prop):
if good_entry is not None and bad_entry is not None:
break
if good_entry is not None and bad_entry is not None:
A = read_bisc_file("../resources/bisc/" + good_entry)
B = read_bisc_file("../resources/bisc/" + bad_entry)
A = read_bisc_file(bisc_dir + "/" + good_entry)
B = read_bisc_file(bisc_dir + "/" + bad_entry)
else:
print("The required files do not exist")
return
Expand Down Expand Up @@ -235,7 +238,11 @@ def auto_bisc(prop):
print("Attempting to read perms from permsets")
good_entry = None
bad_entry = None
with os.scandir("../resources/bisc") as entries:
bisc_dir = os.path.join(
os.path.dirname(__file__), "..", "resources", "bisc"
)
bisc_dir = os.path.abspath(bisc_dir)
with os.scandir(bisc_dir) as entries:
for i, entry in enumerate(entries):
en = entry.name[:-5]
spl = en.split("_")
Expand All @@ -255,8 +262,8 @@ def auto_bisc(prop):
if good_entry is not None and bad_entry is not None:
break
if good_entry is not None and bad_entry is not None:
A = read_bisc_file("../resources/bisc/" + good_entry)
B = read_bisc_file("../resources/bisc/" + bad_entry)
A = read_bisc_file(bisc_dir + "/" + good_entry)
B = read_bisc_file(bisc_dir + "/" + bad_entry)
else:
print("The required files do not exist")
return
Expand Down Expand Up @@ -312,6 +319,8 @@ def read_bisc_file(path):
try:
with open(f"{path}.json", "r") as f:
return from_json(f.readline())
except (ValueError, TypeError, OSError):
except (ValueError, TypeError, OSError) as e:
print(f"File is invalid: {path}")
print(f"Error type: {type(e).__name__}")
print(f"Error message: {e}")
return {}
1 change: 1 addition & 0 deletions permuta/resources/bisc/meander_bad_len8.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions permuta/resources/bisc/meander_good_len8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"0": [[]], "1": [[0]], "2": [[0, 1]], "3": [[0, 1, 2], [2, 1, 0]], "4": [[0, 1, 2, 3], [0, 3, 2, 1], [2, 1, 0, 3]], "5": [[0, 1, 2, 3, 4], [0, 1, 4, 3, 2], [0, 3, 2, 1, 4], [2, 1, 0, 3, 4], [2, 3, 4, 1, 0], [4, 1, 2, 3, 0], [4, 3, 0, 1, 2], [4, 3, 2, 1, 0]], "6": [[0, 1, 2, 3, 4, 5], [0, 1, 2, 5, 4, 3], [0, 1, 4, 3, 2, 5], [0, 3, 2, 1, 4, 5], [0, 3, 4, 5, 2, 1], [0, 5, 2, 3, 4, 1], [0, 5, 4, 1, 2, 3], [0, 5, 4, 3, 2, 1], [2, 1, 0, 3, 4, 5], [2, 1, 0, 5, 4, 3], [2, 3, 4, 1, 0, 5], [4, 1, 2, 3, 0, 5], [4, 3, 0, 1, 2, 5], [4, 3, 2, 1, 0, 5]], "7": [[0, 1, 2, 3, 4, 5, 6], [0, 1, 2, 3, 6, 5, 4], [0, 1, 2, 5, 4, 3, 6], [0, 1, 4, 3, 2, 5, 6], [0, 1, 4, 5, 6, 3, 2], [0, 1, 6, 3, 4, 5, 2], [0, 1, 6, 5, 2, 3, 4], [0, 1, 6, 5, 4, 3, 2], [0, 3, 2, 1, 4, 5, 6], [0, 3, 2, 1, 6, 5, 4], [0, 3, 4, 5, 2, 1, 6], [0, 5, 2, 3, 4, 1, 6], [0, 5, 4, 1, 2, 3, 6], [0, 5, 4, 3, 2, 1, 6], [2, 1, 0, 3, 4, 5, 6], [2, 1, 0, 3, 6, 5, 4], [2, 1, 0, 5, 4, 3, 6], [2, 3, 4, 1, 0, 5, 6], [2, 3, 4, 5, 6, 1, 0], [2, 3, 6, 5, 4, 1, 0], [2, 5, 4, 3, 6, 1, 0], [4, 1, 2, 3, 0, 5, 6], [4, 3, 0, 1, 2, 5, 6], [4, 3, 2, 1, 0, 5, 6], [4, 3, 2, 5, 6, 1, 0], [4, 5, 6, 1, 2, 3, 0], [4, 5, 6, 3, 0, 1, 2], [4, 5, 6, 3, 2, 1, 0], [6, 1, 2, 3, 4, 5, 0], [6, 1, 2, 5, 4, 3, 0], [6, 1, 4, 3, 2, 5, 0], [6, 3, 2, 1, 4, 5, 0], [6, 3, 4, 5, 0, 1, 2], [6, 3, 4, 5, 2, 1, 0], [6, 5, 0, 1, 2, 3, 4], [6, 5, 0, 1, 4, 3, 2], [6, 5, 0, 3, 2, 1, 4], [6, 5, 2, 1, 0, 3, 4], [6, 5, 2, 3, 4, 1, 0], [6, 5, 4, 1, 2, 3, 0], [6, 5, 4, 3, 0, 1, 2], [6, 5, 4, 3, 2, 1, 0]], "8": [[0, 1, 2, 3, 4, 5, 6, 7], [0, 1, 2, 3, 4, 7, 6, 5], [0, 1, 2, 3, 6, 5, 4, 7], [0, 1, 2, 5, 4, 3, 6, 7], [0, 1, 2, 5, 6, 7, 4, 3], [0, 1, 2, 7, 4, 5, 6, 3], [0, 1, 2, 7, 6, 3, 4, 5], [0, 1, 2, 7, 6, 5, 4, 3], [0, 1, 4, 3, 2, 5, 6, 7], [0, 1, 4, 3, 2, 7, 6, 5], [0, 1, 4, 5, 6, 3, 2, 7], [0, 1, 6, 3, 4, 5, 2, 7], [0, 1, 6, 5, 2, 3, 4, 7], [0, 1, 6, 5, 4, 3, 2, 7], [0, 3, 2, 1, 4, 5, 6, 7], [0, 3, 2, 1, 4, 7, 6, 5], [0, 3, 2, 1, 6, 5, 4, 7], [0, 3, 4, 5, 2, 1, 6, 7], [0, 3, 4, 5, 6, 7, 2, 1], [0, 3, 4, 7, 6, 5, 2, 1], [0, 3, 6, 5, 4, 7, 2, 1], [0, 5, 2, 3, 4, 1, 6, 7], [0, 5, 4, 1, 2, 3, 6, 7], [0, 5, 4, 3, 2, 1, 6, 7], [0, 5, 4, 3, 6, 7, 2, 1], [0, 5, 6, 7, 2, 3, 4, 1], [0, 5, 6, 7, 4, 1, 2, 3], [0, 5, 6, 7, 4, 3, 2, 1], [0, 7, 2, 3, 4, 5, 6, 1], [0, 7, 2, 3, 6, 5, 4, 1], [0, 7, 2, 5, 4, 3, 6, 1], [0, 7, 4, 3, 2, 5, 6, 1], [0, 7, 4, 5, 6, 1, 2, 3], [0, 7, 4, 5, 6, 3, 2, 1], [0, 7, 6, 1, 2, 3, 4, 5], [0, 7, 6, 1, 2, 5, 4, 3], [0, 7, 6, 1, 4, 3, 2, 5], [0, 7, 6, 3, 2, 1, 4, 5], [0, 7, 6, 3, 4, 5, 2, 1], [0, 7, 6, 5, 2, 3, 4, 1], [0, 7, 6, 5, 4, 1, 2, 3], [0, 7, 6, 5, 4, 3, 2, 1], [2, 1, 0, 3, 4, 5, 6, 7], [2, 1, 0, 3, 4, 7, 6, 5], [2, 1, 0, 3, 6, 5, 4, 7], [2, 1, 0, 5, 4, 3, 6, 7], [2, 1, 0, 5, 6, 7, 4, 3], [2, 1, 0, 7, 4, 5, 6, 3], [2, 1, 0, 7, 6, 3, 4, 5], [2, 1, 0, 7, 6, 5, 4, 3], [2, 3, 4, 1, 0, 5, 6, 7], [2, 3, 4, 1, 0, 7, 6, 5], [2, 3, 4, 5, 6, 1, 0, 7], [2, 3, 6, 5, 4, 1, 0, 7], [2, 5, 4, 3, 6, 1, 0, 7], [2, 5, 6, 1, 0, 7, 4, 3], [4, 1, 2, 3, 0, 5, 6, 7], [4, 1, 2, 3, 0, 7, 6, 5], [4, 3, 0, 1, 2, 5, 6, 7], [4, 3, 0, 1, 2, 7, 6, 5], [4, 3, 0, 7, 6, 1, 2, 5], [4, 3, 2, 1, 0, 5, 6, 7], [4, 3, 2, 1, 0, 7, 6, 5], [4, 3, 2, 5, 6, 1, 0, 7], [4, 5, 6, 1, 2, 3, 0, 7], [4, 5, 6, 3, 0, 1, 2, 7], [4, 5, 6, 3, 2, 1, 0, 7], [6, 1, 2, 3, 4, 5, 0, 7], [6, 1, 2, 5, 4, 3, 0, 7], [6, 1, 4, 3, 2, 5, 0, 7], [6, 3, 2, 1, 4, 5, 0, 7], [6, 3, 4, 5, 0, 1, 2, 7], [6, 3, 4, 5, 2, 1, 0, 7], [6, 5, 0, 1, 2, 3, 4, 7], [6, 5, 0, 1, 4, 3, 2, 7], [6, 5, 0, 3, 2, 1, 4, 7], [6, 5, 2, 1, 0, 3, 4, 7], [6, 5, 2, 3, 4, 1, 0, 7], [6, 5, 4, 1, 2, 3, 0, 7], [6, 5, 4, 3, 0, 1, 2, 7], [6, 5, 4, 3, 2, 1, 0, 7]]}
Loading