Add CommonRequestOptions to constructor of ScrollPublisher and SearchIterator#3800
Open
ChrisMcD1 wants to merge 1 commit intoPhilippus:series/9.xfrom
Open
Add CommonRequestOptions to constructor of ScrollPublisher and SearchIterator#3800ChrisMcD1 wants to merge 1 commit intoPhilippus:series/9.xfrom
ChrisMcD1 wants to merge 1 commit intoPhilippus:series/9.xfrom
Conversation
Contributor
Author
|
Also, this will need to be integrated with #3724, depending on who merges first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that currently there is no way to make the ScrollPublisher include authentication in its request to elasticsearch, since it calls the
executemethod internally, but has no way to pass in theCommonRequestOptionsthat would contain that authentication.Given that the
ScrollPublisherhas a singularSearchRequestin its construction, I think it makes sense to include the options for that request alongside it.I noticed the same thing in
SearchIterator, and added it toI also searched around the code base, and it seems that the following other classes have calls to
ElasticClient.execute, and no way to pass options to them. However, they do not have their request object taken in at construction, and I am not currently using any of them, so I wasn't sure what the best way to pass in the options to them would be.BulkIndexingSubscriberBatchElasticSinkElasticSourceIf anyone has a workaround to get authentication working with these at all in the interim, I would love to hear it! Currently planning to vendor this dependency with these patches.