Fix: Wrong edge path number in evaluation after variation deletion#3
Closed
SachinDarade wants to merge 1 commit intoPhonePe:mainfrom
Closed
Fix: Wrong edge path number in evaluation after variation deletion#3SachinDarade wants to merge 1 commit intoPhonePe:mainfrom
SachinDarade wants to merge 1 commit intoPhonePe:mainfrom
Conversation
…ation before the edge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the scneario with 4 edges like below:

Issue
Response of evaluation contains
edgePathwhich stores the path in which the edges were successfully chosen.Now suppose the edge with filter
userId = U3gets deleted. Here the number of edge with filteruserId = 4still remains 4.However, this edgeNumber is used in edgePath tracing during evaluation of a key. So what happens is that now suppose context map was
userId = 4then the correct edge with filteruserId = 4gets evaluated however the edgePath response is[4]instead of[3](which is the current position of the edge of U4 in the list of edges ofrootKnotFix
Instead of getting the edge position from edge's number, we instead calculate the position of edge in list of
edgeIdentifiersof a knot by iterating the list and finding the position.