Merged
Conversation
added 2 commits
July 21, 2025 23:05
Contributor
|
Lets rename all references of |
added 2 commits
October 14, 2025 21:25
Tushar-Naik
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces key-aware filtering capabilities into the core evaluation engine by passing the evaluation key down to the filter execution layer. This is achieved by adding a generic associatedEntity field to the ConditionEngine and ConditionalMatcher interfaces, which is then populated with the current evaluation key in BonsaiTree.
This enhancement is foundational for enabling new filter Uniform Sampling Filter.
Bonsai's evaluation engine is the only component with direct, real-time access to the full context required for these new filter. The current key is only available within the BonsaiTree.evaluate() call stack. Placing the logic in Bonsai is efficient, as it avoids a complex and slow process of passing context back and forth with the consuming application.