Fix: Numeric Comparison Precision Loss in JsonPathFilterEvaluationEngine [From: Deepanjan-Fork Repo]#8
Merged
Tushar-Naik merged 2 commits intoPhonePe:mainfrom Jan 16, 2026
Conversation
Collaborator
Author
|
Duplicate of: |
Tushar-Naik
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Numeric filter comparisons (less than, greater than, etc.) were using
floatValue()for comparisons, which caused precision loss for large integers. This resulted in incorrect filter evaluation results.Example of the Bug
Root Cause
Float has only ~7 significant decimal digits of precision, while double has ~15-17 significant digits.
Solution
Changed all numeric comparison methods in JsonPathFilterEvaluationEngine from using floatValue() to doubleValue():
- lessThan()
- lessThanEquals()
- greaterThan()
- greaterThanEquals()
- between()
Testing
Added comprehensive test coverage for large integer comparisons:
- testLessThanFilterWithLargeIntegers - Tests < operator with large integers
- testLessEqualFilterWithLargeIntegers - Tests <= operator with large integers
- testGreaterThanFilterWithLargeIntegers - Tests > operator with large integers
- testGreaterEqualFilterWithLargeIntegers - Tests >= operator with large integers
- testBetweenFilterWithLargeIntegers - Tests between filter with large integers
All existing tests (90 total) continue to pass, ensuring no regressions.