Skip to content

Replace Aruco with Aruco Nano #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Gold856
Copy link
Collaborator

@Gold856 Gold856 commented May 10, 2025

Description

Replaces the old Aruco detector with Aruco Nano v6. The header has been vendored in a mostly unmodified form, with a small modification to how dictionary codes are created to prevent recreating them everytime the detect function is called. The JNI files have been rewritten from https://github.com/PhotonVision/aruconano-jni due to JNI limitations (JNI_OnLoad being defined already in photon-targeting is one of them). Aruco Nano has no config options (other than the fiducal type), so the Aruco tab has been removed. Aruco Nano's accuracy is currently unknown, but it is known to be much faster than the UMich AprilTag detector, and if Aruco Nano has accuracy on par with the UMich AprilTag detector, it could replace the UMich AprilTag detector, providing a significant boost to FPS in vision pipelines.

Closes #1077.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 force-pushed the aruco-nano branch 3 times, most recently from 2369030 to 10a266a Compare May 10, 2025 05:50
@Gold856 Gold856 force-pushed the aruco-nano branch 2 times, most recently from d40006b to e9f1582 Compare July 12, 2025 08:33
@Gold856 Gold856 force-pushed the aruco-nano branch 3 times, most recently from 44c690c to 86b6f4c Compare July 13, 2025 00:33
@Gold856 Gold856 changed the title Add aruconano support Add Aruco Nano support Jul 13, 2025
@Gold856 Gold856 changed the title Add Aruco Nano support Replace Aruco with Aruco Nano Jul 13, 2025
@Gold856 Gold856 marked this pull request as ready for review July 13, 2025 00:35
@Gold856 Gold856 requested a review from a team as a code owner July 13, 2025 00:35
@mcm001
Copy link
Contributor

mcm001 commented Jul 13, 2025

Should probably convert this to draft until we can better characterized noise

@Gold856 Gold856 marked this pull request as draft July 13, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants