Replace Aruco with Aruco Nano #1961
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the old Aruco detector with Aruco Nano v6. The header has been vendored in a mostly unmodified form, with a small modification to how dictionary codes are created to prevent recreating them everytime the detect function is called. The JNI files have been rewritten from https://github.com/PhotonVision/aruconano-jni due to JNI limitations (JNI_OnLoad being defined already in photon-targeting is one of them). Aruco Nano has no config options (other than the fiducal type), so the Aruco tab has been removed. Aruco Nano's accuracy is currently unknown, but it is known to be much faster than the UMich AprilTag detector, and if Aruco Nano has accuracy on par with the UMich AprilTag detector, it could replace the UMich AprilTag detector, providing a significant boost to FPS in vision pipelines.
Closes #1077.
Meta
Merge checklist: